Implement a GAX version of '_PublisherAPI'. #1764

tseaver · 2016-04-28T14:08:39Z

Note: paging methods (list_topics and list_topic_subscriptions) are only partially implemented, because the GAX API does not permit passing in a page token (it cam be coerced into returning only a single page of results, and its token, though). See:

dhermes · 2016-04-28T14:43:19Z

gcloud/pubsub/_gax.py:23:5: E303 too many blank lines (2)
gcloud/pubsub/_gax.py:30:5: E303 too many blank lines (2)
gcloud/pubsub/_gax.py:68:76: W291 trailing whitespace

gcloud/pubsub/_gax.py

+except ImportError:
+    _HAVE_GAX = False
+else:
+    _HAVE_GAX = True


dhermes · 2016-05-03T19:45:23Z

@tseaver To make the conditional definition comments a bit more clear let me describe what I have in mind (as a parallel to oauth2client.crypt).

You implement everything in gcloud.pubsub._gax at the top-level, allowing for import failures.
In the place where you use it (I assume gcloud.pubsub.connection, in a future PR?), there you conditionally import:

try:
    from gcloud.pubsub._gax import _PublisherAPI
    ...
    _HAVE_GAX = True
except ImportError:
    _PublisherAPI = None  # or maybe type(None) if you want it to be a class
    ...
    _HAVE_GAX = False

Having the conditional skip in test__gax rely on the import success also seems out of place, since we can just require the dependency in tox for Py2.7 and ignore it for other versions (I know the dependency is an extra right now in setup.py).

tseaver · 2016-05-06T22:59:58Z

You implement everything in gcloud.pubsub._gax at the top-level, allowing for import failures.

How do you deal with those errors being triggered by tests in the tox environments where the grpc extra cannot be installed? That is what unittest.skipUnless is for, after all.

dhermes · 2016-05-09T18:00:38Z

@tseaver You can still skipUnless, just use gcloud.pubsub.connection._HAVE_GAX.

tseaver · 2016-05-09T18:26:28Z

@dhermes

The new module is the point where we're detecting the presence / absence of GAX.
The future PR will add the import to gcloud.pubsub.client, not connection: it will test the _HAVE_GAX flag, along with an optional environment variable, to determine whether to use the _gax helpers or the JSON ones (from gcloud.pubsub.connection).
Having tests of the "lower-level" module (gcloud.pubsub._gax) rely on the "higher-level" one (gcloud.pubsub.client) is just wrong.

dhermes · 2016-05-09T18:28:47Z

The way you detect it isn't particularly important to me. My feedback is not all-encompassing, just that you don't conditionally define an entire module.

tseaver · 2016-05-10T20:56:36Z

Don't conditionally define an entire module.

What is the difference for the user of the library? In this implementaiton, they can import gcloud.pubsub._gax without an exception, but the only member will be the _HAVE_GAX flag. In your version, trying to import gcloud.pubsub._gax would raise an ImportError.

WIthin gcloud, I can't see any win to deferring handling of the ImportError to the potential user (gcloud.pubsub.client). My way makes it easier to test the conditional code, because I can monkey-patch gcloud.pubsub._gax to have the desired value of _HAVE_GAX, as well as an appropriate stub for the helper objects.

dhermes · 2016-05-11T17:13:36Z

Anything named gcloud.pubsub._gax is not for users. I'm not asking for the change for users, but for code quality. It's harder to read and understand a class defined somewhere other than the top level.

You could even just have _gax.py contain:

try:
    import google.gax
except ImportError:
    _HAVE_GAX = False
else:
    _HAVE_GAX = True
    from gcloud.pubsub._gax_impl import _PublisherAPI

I'm just advocating against conditionally defined top-level objects for the same of the code.

gcloud/pubsub/_gax.py

+else:
+    _HAVE_GAX = True
+
+    from google.pubsub.v1.pubsub_pb2 import PubsubMessage


dhermes · 2016-05-11T17:22:51Z

The cause stuff looks alright, so the last hangup is the conditionally defined stuff.

Note: paging methods ('list_topics' and 'list_topic_subscriptions') are only partially implemented, because the GAX API does not permit passing in a page token (it can be coerced into *returning* only a single page of results, and its token, though). See: - googleapis/gax-python#86 - googleapis/gax-python#94

Addresses: #1764 (comment)

Also, add docstring for private helper function. Addresses: #1764 (comment) #1764 (comment)

I.e., raise 'NotFound' on a miss.

0.14.0 causes google.pubsub.v1 to barf (see: https://github.com/googleapis/googleapis/issues/17).

Addresses: #1764 et ff.

Addresses: #1764 (comment) Drop local 'no-name-in-module' pylint suppression (master now disables it in global config).

Addresses: #1764 (comment)

tseaver · 2016-05-13T02:23:23Z

@dhermes PTAL

dhermes · 2016-05-13T18:33:32Z

@tseaver Trying to review the "latest" changes but all the commits are from May 11 and May 12. Does a rebase change a commit date? Which ones are relevant since last review?

tseaver · 2016-05-13T19:23:34Z

@dhermes

@tseaver Trying to review the "latest" changes but all the commits are from May 11 and May 12. Does a rebase change a commit date?

I've never quite figured out what Github's UI was doing about dates.

Which [commits] are relevant since last review?

dhermes · 2016-05-16T05:50:22Z

LGTM. Sorry for the delay.

* Add Bigtable hello world sample. [(#371)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/371) * Add Bigtable hello world sample. * Update secrets for Bigtable tests. * Add region tags to bigtable/hello sample. Also, change the sample to use sequential keys (with a disclaimer) to match the Java sample. I had forgotten to add a sample usage to get a specific row, so add that, too. * Close HappyBase connection in bigtable/hello sample. I noticed that the `bigtable/hello` sample was not quitting when I sent a `Ctrl-C` this should fix that problem. * bigtable: Move hello to hello_happybase. [(#383)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/383) * bigtable: Move hello to hello_happybase. [(#383)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/383) * bigtable: add raw gcloud-python hello sample. This sample uses the "raw" [gcloud-python Cloud Bigtable package](https://googlecloudplatform.github.io/gcloud-python/stable/bigtable-usage.html). * bigtable: add raw gcloud-python hello sample. This sample uses the "raw" [gcloud-python Cloud Bigtable package](https://googlecloudplatform.github.io/gcloud-python/stable/bigtable-usage.html). * Update Bigtable samples to v2. Table of Contents generated with: doctoc --title '**Table of Contents**' bigtable Needs to wait for next gcloud-python launch. Tested locally with a previous version of grpcio. * Update Bigtable samples to v2. Table of Contents generated with: doctoc --title '**Table of Contents**' bigtable Needs to wait for next gcloud-python launch. Tested locally with a previous version of grpcio. * Auto-update dependencies. [(#456)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/456) * Auto-update dependencies. [(#456)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/456) * Remove grpc-python3 hackiness Change-Id: I6bf9a8acb9ba7d067b3095b5857094cbc322ff58 * Remove grpc-python3 hackiness Change-Id: I6bf9a8acb9ba7d067b3095b5857094cbc322ff58 * Auto-update dependencies. [(#540)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/540) * Auto-update dependencies. [(#540)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/540) * Auto-update dependencies. [(#542)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/542) * Auto-update dependencies. [(#542)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/542) * Move to google-cloud [(#544)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/544) * Move to google-cloud [(#544)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/544) * Fix link to bigtable happybase package. [(#576)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/576) It moved to a new repo. * Generate readmes for most service samples [(#599)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/599) * Generate readmes for most service samples [(#599)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/599) * Update samples to support latest Google Cloud Python [(#656)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/656) * Fix bigtable tests Change-Id: I49b68394ccd5133a64e019e91d1ec0529ffd64b3 * Fix bigtable tests Change-Id: I49b68394ccd5133a64e019e91d1ec0529ffd64b3 * Auto-update dependencies. [(#715)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/715) * Auto-update dependencies. [(#715)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/715) * Auto-update dependencies. [(#781)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/781) * Auto-update dependencies. [(#781)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/781) * Remove cloud config fixture [(#887)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/887) * Remove cloud config fixture * Fix client secrets * Fix bigtable instance * Remove cloud config fixture [(#887)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/887) * Remove cloud config fixture * Fix client secrets * Fix bigtable instance * Auto-update dependencies. [(#914)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/914) * Auto-update dependencies. * xfail the error reporting test * Fix lint * Auto-update dependencies. [(#914)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/914) * Auto-update dependencies. * xfail the error reporting test * Fix lint * Re-generate all readmes * Re-generate all readmes * Auto-update dependencies. [(#922)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/922) * Auto-update dependencies. * Fix pubsub iam samples * Auto-update dependencies. [(#922)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/922) * Auto-update dependencies. * Fix pubsub iam samples * Fix README rst links [(#962)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/962) * Fix README rst links * Update all READMEs * Fix README rst links [(#962)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/962) * Fix README rst links * Update all READMEs * Auto-update dependencies. [(#1004)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1004) * Auto-update dependencies. * Fix natural language samples * Fix pubsub iam samples * Fix language samples * Fix bigquery samples * Auto-update dependencies. [(#1004)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1004) * Auto-update dependencies. * Fix natural language samples * Fix pubsub iam samples * Fix language samples * Fix bigquery samples * Update Bigtable Programmatic Scaling Example [(#1003)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1003) * Update Bigtable Programmatic Scaling Example * Rename "autoscaling" to "metricscaler" and the the term "programmatic scaling" * Remove `strategies.py` to simplify example * Fix wrong sleep length bug * Add maximum node count * hegemonic review * Auto-update dependencies. [(#1005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1005) * Auto-update dependencies. * Fix bigtable lint * Fix IOT iam interaction * Auto-update dependencies. [(#1005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1005) * Auto-update dependencies. * Fix bigtable lint * Fix IOT iam interaction * Auto-update dependencies. [(#1028)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1028) * Auto-update dependencies. [(#1055)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1055) * Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43 * Auto-update dependencies. [(#1055)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1055) * Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43 * Auto-update dependencies. [(#1055)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1055) * Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43 * Auto-update dependencies. [(#1057)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1057) * Auto-update dependencies. [(#1093)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1093) * Auto-update dependencies. * Fix storage notification poll sample Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3 * Fix spanner samples Change-Id: I40069222c60d57e8f3d3878167591af9130895cb * Drop coverage because it's not useful Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522 * Try again to fix flaky logging test Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4 * Auto-update dependencies. [(#1093)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1093) * Auto-update dependencies. * Fix storage notification poll sample Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3 * Fix spanner samples Change-Id: I40069222c60d57e8f3d3878167591af9130895cb * Drop coverage because it's not useful Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522 * Try again to fix flaky logging test Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4 * Auto-update dependencies. [(#1093)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1093) * Auto-update dependencies. * Fix storage notification poll sample Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3 * Fix spanner samples Change-Id: I40069222c60d57e8f3d3878167591af9130895cb * Drop coverage because it's not useful Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522 * Try again to fix flaky logging test Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4 * Auto-update dependencies. [(#1094)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1094) * Auto-update dependencies. * Relax assertions in the ocr_nl sample Change-Id: I6d37e5846a8d6dd52429cb30d501f448c52cbba1 * Drop unused logging apiary samples Change-Id: I545718283773cb729a5e0def8a76ebfa40829d51 * Auto-update dependencies. [(#1094)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1094) * Auto-update dependencies. * Relax assertions in the ocr_nl sample Change-Id: I6d37e5846a8d6dd52429cb30d501f448c52cbba1 * Drop unused logging apiary samples Change-Id: I545718283773cb729a5e0def8a76ebfa40829d51 * Update all generated readme auth instructions [(#1121)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1121) Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2 * Update all generated readme auth instructions [(#1121)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1121) Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2 * Update all generated readme auth instructions [(#1121)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1121) Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2 * Bigtable autoscaler: use size variable [(#1156)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1156) * Added Link to Python Setup Guide [(#1158)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1158) * Update Readme.rst to add Python setup guide As requested in b/64770713. This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation. * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update install_deps.tmpl.rst * Updated readmegen scripts and re-generated related README files * Fixed the lint error * Added Link to Python Setup Guide [(#1158)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1158) * Update Readme.rst to add Python setup guide As requested in b/64770713. This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation. * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update install_deps.tmpl.rst * Updated readmegen scripts and re-generated related README files * Fixed the lint error * Added Link to Python Setup Guide [(#1158)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1158) * Update Readme.rst to add Python setup guide As requested in b/64770713. This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation. * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update install_deps.tmpl.rst * Updated readmegen scripts and re-generated related README files * Fixed the lint error * Auto-update dependencies. [(#1186)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1186) * Auto-update dependencies. [(#1186)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1186) * Auto-update dependencies. [(#1186)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1186) * Auto-update dependencies. [(#1199)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1199) * Auto-update dependencies. * Fix iot lint Change-Id: I6289e093bdb35e38f9e9bfc3fbc3df3660f9a67e * Auto-update dependencies. [(#1199)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1199) * Auto-update dependencies. * Fix iot lint Change-Id: I6289e093bdb35e38f9e9bfc3fbc3df3660f9a67e * Auto-update dependencies. [(#1199)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1199) * Auto-update dependencies. * Fix iot lint Change-Id: I6289e093bdb35e38f9e9bfc3fbc3df3660f9a67e * Added "Open in Cloud Shell" buttons to README files [(#1254)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1254) * Added "Open in Cloud Shell" buttons to README files [(#1254)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1254) * Added "Open in Cloud Shell" buttons to README files [(#1254)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1254) * Auto-update dependencies. [(#1377)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1377) * Auto-update dependencies. * Update requirements.txt * Auto-update dependencies. [(#1377)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1377) * Auto-update dependencies. * Update requirements.txt * Auto-update dependencies. [(#1377)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1377) * Auto-update dependencies. * Update requirements.txt * Regenerate the README files and fix the Open in Cloud Shell link for some samples [(#1441)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1441) * Regenerate the README files and fix the Open in Cloud Shell link for some samples [(#1441)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1441) * Regenerate the README files and fix the Open in Cloud Shell link for some samples [(#1441)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1441) * Update READMEs to fix numbering and add git clone [(#1464)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1464) * Update READMEs to fix numbering and add git clone [(#1464)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1464) * Update READMEs to fix numbering and add git clone [(#1464)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1464) * Add Bigtable table admin sample [(#1549)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1549) * Update tableadmin [(#1562)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1562) Fixes #1555 * Cloud Bigtable Quickstarts [(#1616)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1616) * quickstart * quickstart happybase * linting and making tests workˆ * Tidying up * Trigger * Fixes for Python3 * Showing default values for the quickstart functions * Fix lint issue with indentation * Cloud Bigtable Quickstarts [(#1616)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1616) * quickstart * quickstart happybase * linting and making tests workˆ * Tidying up * Trigger * Fixes for Python3 * Showing default values for the quickstart functions * Fix lint issue with indentation * Bigtable: Update tableadmin sample to point to latest release. [(#1665)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1665) * Update tableadmin sample to point to latest release. * update tableadmin * Bigtable: update helloworld example [(#1670)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1670) * Update helloworld example * Use iterable PartialRowsData * Bigtable: Create Instanceadmin sample [(#1664)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1664) * Python instanceadmin sample instanceadmin python sample * Updated instanceadmin.py * modify instanceadmin as per comments * Update instanceadmin.py as per the local review comments. * Update instanceadmin * update instanceadmin, to fix ci failures. * update instanceadmin * update instanceadmin * Implement review comments * Upgrading the metrics query to the latest version [(#1674)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1674) * Upgrading the metrics query to the latest version * fix lint issues * Importing module not class * Fixed print statements [(#1755)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1755) * Updated trampoline script to match latest version that cleans up files * Added newline to end of trampoline script * A quickstart test was missing requirements.txt * Replaced print statements with print function calls * Missed a print issue last time * Bad indent fixed * Fixed print statements [(#1755)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1755) * Updated trampoline script to match latest version that cleans up files * Added newline to end of trampoline script * A quickstart test was missing requirements.txt * Replaced print statements with print function calls * Missed a print issue last time * Bad indent fixed * Fixed print statements [(#1755)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1755) * Updated trampoline script to match latest version that cleans up files * Added newline to end of trampoline script * A quickstart test was missing requirements.txt * Replaced print statements with print function calls * Missed a print issue last time * Bad indent fixed * Making bigtable tests run successfully [(#1764)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1764) * Making bigtable tests run successfully * Fixed missing import * Renamed noxfile for new environment * Moving the nox name back * Making bigtable tests run successfully [(#1764)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1764) * Making bigtable tests run successfully * Fixed missing import * Renamed noxfile for new environment * Moving the nox name back * Added Bu Sun's updates, fixed some lint errors [(#1770)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1770) * Added Bu Sun's updates, fixed some lint errors * Changes to use new nox version * Minor formatting to force a presubmit check to run * Ignore noxfile.py for tests * Clean up layout for lint * updating to latest happy base client version [(#1794)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1794) * Auto-update dependencies. [(#1846)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1846) ACK, merging. * Auto-update dependencies. [(#1846)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1846) ACK, merging. * Auto-update dependencies. [(#1846)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1846) ACK, merging. * Auto-update dependencies. [(#1846)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1846) ACK, merging. * Auto-update dependencies. [(#1846)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1846) ACK, merging. * Auto-update dependencies. [(#1846)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1846) ACK, merging. * Bigtable: add filter region tag to hello world [(#1878)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1878) * use row.cell rather than row.cell_value in the example add 'filter' and 'dependencies' region tags * move the comment line * [bigtable] Clean up quickstart comments and vars [(#1890)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1890) Clean up comments and variable names as this quickstart will be sourced directly into our quickstart docs. * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * Auto-update dependencies. [(#1980)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * New library version to address failure. [(#2057)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2057) * New library version to address failure. * Encoded strings for library call * Give changes a bit longer to finish * fix lint error * Update main.py * Paren was missing * New library version to address failure. [(#2057)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2057) * New library version to address failure. * Encoded strings for library call * Give changes a bit longer to finish * fix lint error * Update main.py * Paren was missing * remove broken test config [(#2054)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2054) * remove broken test config [(#2054)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2054) * Cloud Bigtable Region tag consistency [(#2018)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2018) * Updating the region tags to be consistent across Cloud Bigtable. Need to figure out filtering for happybase or rename * Remove happybase filter * Linting * Cloud Bigtable Region tag consistency [(#2018)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2018) * Updating the region tags to be consistent across Cloud Bigtable. Need to figure out filtering for happybase or rename * Remove happybase filter * Linting * Deflake bigtable and spanner tests. [(#2224)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2224) * Spanner doesn't actually promise the order of the results, so make the assertion work regardless of ordering. * Bigtable might need some more time to scale, so retry the assertion up to 10 times. * Cloud Bigtable writes samples [(#2201)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2201) * Bigtable write samples * Cleaning up test * Fixing lint issues * Fixing imports in test * Cleaning up samples and showing error handling * removing note about the row commit bug * Add fixture to write test * Use test fixtures to create and delete test tables. * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Adds updates including compute [(#2436)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2436) * Adds updates including compute * Python 2 compat pytest * Fixing weird \r\n issue from GH merge * Put asset tests back in * Re-add pod operator test * Hack parameter for k8s pod operator * Auto-update dependencies. [(#2005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Doug Mahugh <[email protected]> * Auto-update dependencies. [(#2005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Doug Mahugh <[email protected]> * Auto-update dependencies. [(#2005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Doug Mahugh <[email protected]> * Auto-update dependencies. [(#2005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Doug Mahugh <[email protected]> * Auto-update dependencies. [(#2005)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Doug Mahugh <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * Cleanup bigtable python examples [(#2692)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2692) * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * remove core dep Co-authored-by: Leah E. Cole <[email protected]> * chore(deps): update dependency google-cloud-core to v1.3.0 [(#3066)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3066) * bigtable: read and filter snippets [(#2707)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2707) * Bigtable write samples * Cleaning up test * Fixing lint issues * Fixing imports in test * Cleaning up samples and showing error handling * removing note about the row commit bug * Add fixture to write test * Read snippets WIP * Cleanup bigtable python: Use new row types for mutations Update bigtable version in requirements Delete table after tests * Change bigtable cluster variable to bigtable instance for consistency Create and delete quickstart table during test * Fixing step size for metric scaler Create unique tables for quickstart tests * Creating fixtures for quickstart tests Fixing hb quickstart test output * Fix quickstart extra delete table Update happybase to use direct row * Use clearer instance names for tests Create unique instances for metric scaler tests * Linting * get session issue in test sorted out * Read snippets with tests working * Filter snippets with tests working * Lint * Update module import * Fix bigtable instance env var * Change scope to module * Don't print empty parens * sort cols * sort by cfs too * Make requirements more specific to samples. LInt fixes Co-authored-by: Leah E. Cole <[email protected]> Co-authored-by: Christopher Wilcox <[email protected]> * bigtable/metricscaler: Add Dockerfile [(#3103)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3103) * bigtable/metricscaler: Add Dockerfile. * Add copyright header * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * Simplify noxfile setup. [(#2806)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update dependency google-cloud-monitoring to v0.35.0 [(#3459)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3459) Co-authored-by: Leah E. Cole <[email protected]> * [bigtable] fix: wrap sample invocations with retries [(#3494)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3494) fix #3070 Also added `BIGTABLE_INSTANCE` to testing/test-env.tmpl.sh * bigtable: Handle dev instances and use storage utilization in metric scaler [(#3119)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3119) * WIP handle development instances in metric scaler * use storage utilization and tested * Fix metric queries * remove tests for low storage util * cleanup metric query * EOF new line * use uuid instead of random * lint * fix uuid length * fix uuid length * fix uuid length (again) Co-authored-by: Christopher Wilcox <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]> * chore: some lint fixes [(#3738)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3738) * chore: some lint fixes [(#3738)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3738) * chore: some lint fixes [(#3738)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3738) * chore: some lint fixes [(#3739)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3739) * chore: some lint fixes [(#3739)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3739) * chore: some lint fixes [(#3740)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3740) * chore(deps): update dependency google-cloud-monitoring to v0.36.0 [(#3783)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3783) Co-authored-by: Leah E. Cole <[email protected]> * testing: various cleanups [(#3877)](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3877) * testing: various cleanups * [iap]: only run iap tests on Kokoro * [vision/automl]: use temporary directory for temporary files * [appengine/flexible/scipy]: use temporary directory * [bigtable/snippets/reads]: update pytest snapshot * [texttospeech/cloud-client]: added output.mp3 to .gitignore * [iot/api-client/gcs_file_to_device]: use temporary directory * [iot/api-client/mqtt_example]: use temporary directory * [logging/cloud-client]: use uuid and add backoff * use project directory with Trampoline V1 * chore: update templates * chore: add noxfiles for all sample projects * docs: add multiprocessing Co-authored-by: Tim Swast <[email protected]> Co-authored-by: Bill Prin <[email protected]> Co-authored-by: DPE bot <[email protected]> Co-authored-by: Jon Wayne Parrott <[email protected]> Co-authored-by: michaelawyu <[email protected]> Co-authored-by: Frank Natividad <[email protected]> Co-authored-by: sangramql <[email protected]> Co-authored-by: Billy Jacobson <[email protected]> Co-authored-by: Charles Engelke <[email protected]> Co-authored-by: sumit-ql <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Misha Brukman <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Thea Flowers <[email protected]> Co-authored-by: Gus Class <[email protected]> Co-authored-by: Kurtis Van Gent <[email protected]> Co-authored-by: Doug Mahugh <[email protected]> Co-authored-by: Leah E. Cole <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Christopher Wilcox <[email protected]> Co-authored-by: Matt Braymer-Hayes <[email protected]> Co-authored-by: Takashi Matsuo <[email protected]>

tseaver added the api: pubsub Issues related to the Pub/Sub API. label Apr 28, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2016

dhermes reviewed Apr 28, 2016
View reviewed changes

gcloud/pubsub/_gax.py Outdated

except ImportError:

_HAVE_GAX = False

else:

_HAVE_GAX = True

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed May 11, 2016
View reviewed changes

gcloud/pubsub/_gax.py Outdated

else:

_HAVE_GAX = True

from google.pubsub.v1.pubsub_pb2 import PubsubMessage

This comment was marked as spam.

Sign in to view

tseaver added 4 commits May 11, 2016 17:47

Normalize JSON API method docstrings.

867ffe9

s/fully-qualfied/fully-qualified/g

9962e36

Addresses: #1764 (comment)

Use 'gcloud._helpers._to_bytes'.

03d55a1

Also, add docstring for private helper function. Addresses: #1764 (comment) #1764 (comment)

tseaver added 9 commits May 11, 2016 17:47

Install 'gcloud[grpc]' deps for coveralls run.

ec04569

Add tests for miss/conflict failure cases to JSON Topic API helper.

6b30128

Make GAX 'topic_delete' consistent w/ JSON version.

609f323

I.e., raise 'NotFound' on a miss.

Pin grpcio at 0.13.1.

cbc24de

0.14.0 causes google.pubsub.v1 to barf (see: https://github.com/googleapis/googleapis/issues/17).

Narrow redirected GaxErrors using 'cause.code'.

e5f034b

Addresses: #1764 et ff.

Don't shadow 'grpc' via '_testing' stubs.

20bea75

Move GAX-dependent class to top-level scope.

4877f5b

Addresses: #1764 (comment) Drop local 'no-name-in-module' pylint suppression (master now disables it in global config).

Coverage for unexpected GaxError.

a3cc3b1

Addresses: #1764 (comment)

coveralls: Don't shadow 'grpc' via '_testing' stubs.

46720fa

tseaver mentioned this pull request May 13, 2016

Add GAX-based _SubscriberAPI. #1795

Merged

tseaver merged commit 14b1143 into googleapis:master May 16, 2016

tseaver deleted the pubsub-wrap_gax_publisher_api branch May 16, 2016 13:48

tseaver mentioned this pull request May 16, 2016

Cut 0.14.0 release. #1799

Merged

dhermes mentioned this pull request May 17, 2016

Why are we pinned to grpcio == 0.13.1 #1801

Closed

parthea pushed a commit that referenced this pull request Nov 26, 2025

chore: update secret (#1764)

8b9c5d9

Implement a GAX version of '_PublisherAPI'. #1764

Implement a GAX version of '_PublisherAPI'. #1764

Uh oh!

Conversation

tseaver commented Apr 28, 2016

Uh oh!

dhermes commented Apr 28, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 3, 2016

Uh oh!

tseaver commented May 6, 2016

Uh oh!

dhermes commented May 9, 2016

Uh oh!

tseaver commented May 9, 2016

Uh oh!

dhermes commented May 9, 2016

Uh oh!

tseaver commented May 10, 2016

Uh oh!

dhermes commented May 11, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 11, 2016

Uh oh!

tseaver commented May 13, 2016

Uh oh!

dhermes commented May 13, 2016

Uh oh!

tseaver commented May 13, 2016

Uh oh!

dhermes commented May 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants