chore: remove name_pretty_override from selected packages#16861
chore: remove name_pretty_override from selected packages#16861parthea merged 6 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames several services across documentation and metadata, notably removing the 'Google Cloud' prefix for BigQuery, Pub/Sub, and Storage, and renaming 'Google APIs Common Protos' to 'Service Config'. Feedback focuses on correcting RST formatting where title underlines were not adjusted to match new title lengths. Additionally, suggestions were made to improve the grammar of service enablement steps in the Pub/Sub README files by removing redundant articles.
| 1. `Select or create a Cloud Platform project.`_ | ||
| 2. `Enable billing for your project.`_ | ||
| 3. `Enable the Google Cloud Pub/Sub.`_ | ||
| 3. `Enable the Cloud Pub/Sub.`_ |
There was a problem hiding this comment.
The phrase 'Enable the Cloud Pub/Sub' is grammatically awkward. It is recommended to remove 'the' for a more natural phrasing, consistent with other service enablement steps.
| 3. `Enable the Cloud Pub/Sub.`_ | |
| 3. Enable Cloud Pub/Sub._ |
| .. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project | ||
| .. _Enable billing for your project.: https://cloud.google.com/billing/docs/how-to/modify-project#enable_billing_for_a_project | ||
| .. _Enable the Google Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs | ||
| .. _Enable the Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs |
There was a problem hiding this comment.
Updating the link label to match the suggested change in the list above.
| .. _Enable the Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs | |
| .. _Enable Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs |
| 1. `Select or create a Cloud Platform project.`_ | ||
| 2. `Enable billing for your project.`_ | ||
| 3. `Enable the Google Cloud Pub/Sub.`_ | ||
| 3. `Enable the Cloud Pub/Sub.`_ |
There was a problem hiding this comment.
The phrase 'Enable the Cloud Pub/Sub' is grammatically awkward. It is recommended to remove 'the' for a more natural phrasing.
| 3. `Enable the Cloud Pub/Sub.`_ | |
| 3. Enable Cloud Pub/Sub._ |
| .. _Select or create a Cloud Platform project.: https://console.cloud.google.com/project | ||
| .. _Enable billing for your project.: https://cloud.google.com/billing/docs/how-to/modify-project#enable_billing_for_a_project | ||
| .. _Enable the Google Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs | ||
| .. _Enable the Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs |
There was a problem hiding this comment.
Updating the link label to match the suggested change in the list above.
| .. _Enable the Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs | |
| .. _Enable Cloud Pub/Sub.: https://cloud.google.com/pubsub/docs |
| @@ -1,4 +1,4 @@ | |||
| Python Client for Google Cloud Storage | |||
| Python Client for Cloud Storage | |||
There was a problem hiding this comment.
The underline on the next line (line 2) should be updated to match the new title length (31 characters). It is currently 38 characters long, which was the length of the previous title. Note that this was correctly updated in the Pub/Sub README in this same PR.
| @@ -1,4 +1,4 @@ | |||
| Python Client for Google Cloud Storage | |||
| Python Client for Cloud Storage | |||
There was a problem hiding this comment.
The underline on the next line (line 2) should be updated to match the new title length (31 characters).
jskeet
force-pushed
the
remove-name-pretty-override-4
branch
from
fbb5101 to
7634abd
Compare
This removes name_pretty_override from just four packages: - google-cloud-storage - google-cloud-bigquery-storage - google-cloud-pubsub - googleapis-common-protos These are the packages with post-processing files that need changing at the same time.
jskeet
force-pushed
the
remove-name-pretty-override-4
branch
from
7634abd to
30673c1
Compare
This omits django-spanner and gapic-generator (which currently have failing tests) and the packages modified in googleapis#16861.
2 participants
This removes name_pretty_override from just four packages:
These are the packages with post-processing files that need changing at the same time.