fix(auth): Disable MDS mTLS feature by default.#16786
Merged
nolanleastin merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
mTLS connection to MDS is failing after a python update. There is a bug in the failover logic that is affecting some users. This PR: - disables the feature until the failover logic and mTLS connection are fixed. - fixes metadata unit tests which were failing due to some get_and_parse_agent_identity_certificate requirement
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default GCE metadata mTLS mode from 'default' to 'none' and adjusts the associated unit tests. It also introduces mocks for agent identity certificate retrieval in several Compute Engine service account token tests to maintain test isolation. I have no feedback to provide.
daniel-sanche
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mTLS connection to MDS is failing after a python update. There is a bug in the failover logic that is affecting some users.
This PR:
Fixes #16090