chore: librarian generate pull request: 20260408T070849Z#16576
Conversation
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Google Cloud client libraries, most notably introducing "Sections" management functionality to the Google Apps Chat library and adding shared regional certificate authority support to Memorystore. Other updates include new checksum fields in Storage and mime_type support in Translation. Feedback highlights a potential code generation error in the Translation library where the mime_type field was incorrectly added to GlossaryConfig instead of AdaptiveMtTranslateRequest. Additionally, a docstring inconsistency was identified in the Chat library regarding the retention of a "Developer Preview" notice that should be removed to match other updates in the PR.
| mime_type: str = proto.Field( | ||
| proto.STRING, | ||
| number=4, | ||
| ) |
There was a problem hiding this comment.
The mime_type field is being added to GlossaryConfig. However, the commit message for this change ("feat: A new field mime_type is added to message .google.cloud.translation.v3.AdaptiveMtTranslateRequest") and the corresponding proto change in googleapis/googleapis@d6837a5d indicate that this field should be part of AdaptiveMtTranslateRequest directly, not GlossaryConfig. This appears to be a code generation issue.
| r"""Request message for deleting a section. `Developer | ||
| Preview <https://developers.google.com/workspace/preview>`__. |
There was a problem hiding this comment.
The docstring for DeleteSectionRequest includes a "Developer Preview" notice. This seems inconsistent with other changes in this PR that remove similar notices from other docstrings. For consistency, this should be removed if the feature is generally available.
r"""Request message for deleting a section."""
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
docs: Fix documentation URL AIInference MessageTransform service_account_email field
PiperOrigin-RevId: 895485801
Library-IDs: google-cloud-pubsub
Source-link: googleapis/googleapis@afb6d4b3
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
mime_typeis added to message.google.cloud.translation.v3.AdaptiveMtTranslateRequestPiperOrigin-RevId: 895422613
Library-IDs: google-cloud-translate
Source-link: googleapis/googleapis@d6837a5d
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: populate the
persisted_data_checksumsfield with object checksums on write object / query write status responsesPiperOrigin-RevId: 895357062
Library-IDs: google-cloud-storage
Source-link: googleapis/googleapis@d73dfb3c
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: improve wording around
object_checksumsin bidi write object requestsPiperOrigin-RevId: 895357062
Library-IDs: google-cloud-storage
Source-link: googleapis/googleapis@d73dfb3c
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: added support for detecting key-value pairs in client provided metadata
PiperOrigin-RevId: 895098649
Library-IDs: google-cloud-dlp
Source-link: googleapis/googleapis@544bab0c
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Support app authentication with admin-consent scopes for Chat API ListMessages, GetMessage, GetSpaceEvent and ListSpaceEvents
PiperOrigin-RevId: 893619899
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@8d52a0bd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Update reference documentation for Chat API ListMessages, GetMessage, GetSpaceEvent and ListSpaceEvents.
PiperOrigin-RevId: 893619899
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@8d52a0bd
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Addition of Section and SectionItem APIs
PiperOrigin-RevId: 893488928
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@76fdbf75
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@582172de
(exclusive) and
googleapis/googleapis@afb6d4b3
(inclusive).
Librarian Version: v0.0.0-20260407125916-07fdb844a681
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
Generation failed for