chore: librarian generate pull request: 20260311T104913Z#16073
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the generation of Cloud Client Libraries code for Google Cloud Pub/Sub. The primary change is the addition of a Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated by the Librarian CLI, introduces the BigtableConfig type for Pub/Sub subscriptions. The changes are mostly correct, and the minor issues previously identified regarding field ordering and a typo in the docstring remain valid and would improve code quality and consistency.
|
|
||
| - row key: subscription name and message ID delimited by #. | ||
| - columns: message bytes written to a single column family | ||
| "data" with an empty-string column qualifier. |
There was a problem hiding this comment.
There seems to be a minor typo here with extra spaces. It should be 'an empty-string' instead of 'an empty-string'.
| "data" with an empty-string column qualifier. | |
| "data" with an empty-string column qualifier. |
| table: str = proto.Field( | ||
| proto.STRING, | ||
| number=1, | ||
| ) | ||
| app_profile_id: str = proto.Field( | ||
| proto.STRING, | ||
| number=2, | ||
| ) | ||
| service_account_email: str = proto.Field( | ||
| proto.STRING, | ||
| number=3, | ||
| ) | ||
| write_metadata: bool = proto.Field( | ||
| proto.BOOL, | ||
| number=5, | ||
| ) | ||
| state: State = proto.Field( | ||
| proto.ENUM, | ||
| number=4, | ||
| enum=State, | ||
| ) |
There was a problem hiding this comment.
For better readability and consistency with other message definitions in this file, it's recommended to order the fields by their number attribute. The state field (number=4) should come before the write_metadata field (number=5).
table: str = proto.Field(
proto.STRING,
number=1,
)
app_profile_id: str = proto.Field(
proto.STRING,
number=2,
)
service_account_email: str = proto.Field(
proto.STRING,
number=3,
)
state: State = proto.Field(
proto.ENUM,
number=4,
enum=State,
)
write_metadata: bool = proto.Field(
proto.BOOL,
number=5,
)
chalmerlowe
added
the
automerge
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Add BigtableConfig type
PiperOrigin-RevId: 878685355
Library-IDs: google-cloud-pubsub
Source-link: googleapis/googleapis@23ec7b6e
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@ce8678a9
(exclusive) and
googleapis/googleapis@23ec7b6e
(inclusive).
Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c