Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 8, 2016

Nice bonus: we get to remove a bunch of '# pylint: disable=E0401'.

Nice bonus:  we get to remove a bunch of '# pylint: disable=E0401'.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

LGTM

tseaver added a commit that referenced this pull request Mar 8, 2016
…otobf

Hide 'six' and 'google.protobuf' from pylint's borked import sniffing.
@tseaver tseaver merged commit 95238be into googleapis:logging-api Mar 8, 2016
@tseaver tseaver deleted the pylint-ignore_six_and_google_protobf branch March 8, 2016 15:58
@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

FYI this broke the Windows CI: 95238be279

@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2016

I don't see anything related to the PR on the failed Python 3.5 job: the only message I see is,

Build execution time has reached the maximum allowed time for your plan (60 minutes).

@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

Good deal. I am just on my phone so fairly limited in what I can see. I restarted the build. No idea why we'd hit 60m

@tseaver
Copy link
Contributor Author

tseaver commented Mar 8, 2016

No idea why we'd hit 60m

Lots of PRs running at the same time? I am kicking in a bunch of logging work in small slices.

@dhermes
Copy link
Contributor

dhermes commented Mar 8, 2016

AppVeyor only runs on merges, not PRs. No worries.

parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
* chore: initial setup for async auth sessions api (#1571)

* chore: initial setup for async auth sessions api

* fix whitespace

* add init file

* update file names to aiohttp

* update import statement

* feat: Implement asynchronous timeout context manager (#1569)

* feat: implement async timeout guard

* add docstring

* clean whitespace

* update import file name

* add missing return statement

* update test cases

* update test cases

* include underlying timeout exception in trace

* avoid the cost of actual time

* feat: Implement asynchronous `AuthorizedSession` api response class (#1575)

* feat: implement asynchronous response class for AuthorizedSessions API

* check if aiohttp is installed and avoid tests dependency

* update content to be async

* update docstring to be specific to aiohttp

* add type checking and avoid leaking underlying API responses

* add test case for iterating chunks

* add read method to response interface

* address PR comments

* fix lint issues

* feat: Implement asynchronous `AuthorizedSession` api request class (#1579)

* feat: implement request class for asynchoronous AuthorizedSession API

* add type checking and address TODOs

* remove default values from interface methods

* aiohttp reponse close method must not be awaited

* cleanup

* update Request class docstring

* feat: Implement asynchronous `AuthorizedSession` class (#1580)

* feat: Implement Asynchronous AuthorizedSession class

* add comment for implementing locks within refresh

* move timeout guard to sessions

* add unit tests and code cleanup

* implement async exponential backoff iterator

* cleanup

* add testing for http methods and cleanup

* update number of retries to 3

* refactor test cases

* fix linter and mypy issues

* fix pytest code coverage

* fix: avoid leaking api error for closed session

* add error handling for response

* cleanup default values and add test coverage

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: minor code cleanup (#1589)

* chore: Add aiohttp requirements test constraint. (#1566)

See googleapis/google-auth-library-python#1565
for more information.

* chore(main): release 2.33.0 (#1560)

* chore(main): release 2.33.0

* fix: retry token request on retryable status code (#1563)

* fix: retry token request on retryable status code

* feat(auth): Update get_client_ssl_credentials to support X.509 workload certs (#1558)

* feat(auth): Update get_client_ssl_credentials to support X.509 workload certs

* feat(auth): Update has_default_client_cert_source

* feat(auth): Fix formatting

* feat(auth): Fix test__mtls_helper.py

* feat(auth): Fix function name in tests

* chore: Refresh system test creds.

* feat(auth): Fix style

* feat(auth): Fix casing

* feat(auth): Fix linter issue

* feat(auth): Fix coverage issue

---------

Co-authored-by: Carl Lundin <[email protected]>
Co-authored-by: Carl Lundin <[email protected]>

* chore: Update ECP deps. (#1583)

* chore(main): release 2.34.0 (#1574)

* cleanup: minor code cleanup

* fix lint issues

---------

Co-authored-by: Carl Lundin <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Andy Zhao <[email protected]>
Co-authored-by: Carl Lundin <[email protected]>

* update secrets from forked repo

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: arithmetic1728 <[email protected]>
Co-authored-by: Carl Lundin <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Andy Zhao <[email protected]>
Co-authored-by: Carl Lundin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants