tests(google-cloud-bigquery-storage): drop usage of pytz in tests/*.py by parthea · Pull Request #15480 · googleapis/google-cloud-python

parthea · 2026-01-22T17:46:13Z

This PR resolves the following failure which appears in

==================================== ERRORS ====================================
________________ ERROR collecting tests/unit/test_reader_v1.py _________________
ImportError while importing test module '/tmpfs/src/github/google-cloud-python/packages/google-cloud-bigquery-storage/tests/unit/test_reader_v1.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.14/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/unit/test_reader_v1.py:31: in 
    from .helpers import SCALAR_BLOCKS, SCALAR_COLUMN_NAMES, SCALAR_COLUMNS
tests/unit/helpers.py:20: in 
    import pytz
E   ModuleNotFoundError: No module named 'pytz'
_____________ ERROR collecting tests/unit/test_reader_v1_arrow.py ______________
ImportError while importing test module '/tmpfs/src/github/google-cloud-python/packages/google-cloud-bigquery-storage/tests/unit/test_reader_v1_arrow.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.14/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/unit/test_reader_v1_arrow.py:33: in 
    from .helpers import SCALAR_BLOCKS, SCALAR_COLUMN_NAMES, SCALAR_COLUMNS
tests/unit/helpers.py:20: in 
    import pytz
E   ModuleNotFoundError: No module named 'pytz'

pytz was used in tests but not explicitly installed. This PR removes usage of pytz in tests, although it is still needed transitively via pandas

…of pandas

gemini-code-assist · 2026-01-22T17:46:31Z

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the test suite for the google-cloud-bigquery-storage library to eliminate direct reliance on the pytz library for timezone handling. Instead, it leverages the built-in datetime.timezone.utc for defining UTC timezones in tests. This change modernizes the codebase by utilizing standard library features and streamlines test dependencies, while ensuring pytz remains available as an indirect dependency for pandas where required.

Highlights

Test Modernization: The direct usage of the pytz library for timezone handling in system and unit tests has been removed, opting instead for the standard library's datetime.timezone.utc.
Dependency Management: Unnecessary test dependencies cachetools and cryptography were removed from noxfile.py. pytz was explicitly added as a dependency in generator-input and constraints-3.7.txt to ensure pandas functionality, which may rely on pytz.
Metadata Update: The last_generated_commit for google-cloud-bigquery-storage in .librarian/state.yaml was updated, likely reflecting a regeneration of client library configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively removes the direct dependency on pytz in the test suite by migrating to the standard library's datetime.timezone.utc. This is a great improvement for modernizing the codebase. I've added a few suggestions regarding dependency management best practices: pinning the version of the newly added pytz dependency for reproducibility, and keeping pull requests focused on a single concern. Overall, the changes are in a good direction.

gemini-code-assist · 2026-01-22T17:47:54Z

      libcst==0.2.5
      fastavro==0.21.2
+      # pytz is required by pandas
+      pytz


To ensure reproducible builds, it's a good practice to pin dependency versions. Please specify a version for pytz. For example, pytz==2023.3.

pytz==2023.3

gemini-code-assist · 2026-01-22T17:47:54Z

 PACKAGE_NAME = "google-cloud-bigquery-storage"

 UNIT_TEST_STANDARD_DEPENDENCIES = [
-    "cachetools",


This dependency removal is out of scope for this PR, which focuses on pytz. To maintain a clean and atomic commit history, it's best to handle unrelated changes in separate pull requests.

gemini-code-assist · 2026-01-22T17:47:54Z

 SYSTEM_TEST_LOCAL_DEPENDENCIES: List[str] = []
 SYSTEM_TEST_DEPENDENCIES: List[str] = []
 SYSTEM_TEST_EXTRAS: List[str] = [
-    "cryptography",


Similar to the cachetools removal, this change is out of scope for this PR. Please group related changes into a single PR and keep unrelated changes separate for better reviewability and a cleaner commit history.

gemini-code-assist · 2026-01-22T17:47:54Z

 libcst==0.2.5
 fastavro==0.21.2
+# pytz is required by pandas
+pytz


For reproducible test runs, it's a good practice to pin all dependencies in a constraints file. Please add a specific version for pytz. For example, pytz==2023.3.

pytz==2023.3

parthea added 2 commits January 21, 2026 20:23

drop usage of pytz in tests; add pytz to constraints as a dependency …

7dfe8f5

…of pandas

re-run generation for google-cloud-bigquery-storage

a78e73a

gemini-code-assist Bot reviewed Jan 22, 2026

View reviewed changes

parthea added 2 commits January 22, 2026 18:04

apply fix from googleapis/gapic-generator-python#2527

fa6b3ef

lint

70bc937

parthea marked this pull request as ready for review January 22, 2026 18:18

parthea requested review from a team January 22, 2026 18:18

parthea requested a review from a team as a code owner January 22, 2026 18:18

parthea requested a review from logachev January 22, 2026 18:18

Linchin approved these changes Jan 22, 2026

View reviewed changes

Linchin merged commit d6af4ab into main Jan 22, 2026
26 checks passed

Linchin deleted the re-generate-bq-storage branch January 22, 2026 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests(google-cloud-bigquery-storage): drop usage of pytz in tests/*.py#15480

tests(google-cloud-bigquery-storage): drop usage of pytz in tests/*.py#15480
Linchin merged 4 commits intomainfrom
re-generate-bq-storage

parthea commented Jan 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jan 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

parthea commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 22, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

parthea commented Jan 22, 2026 •

edited

Loading