Introducing basic system test for Bigtable. #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
system_tests/bigtable.py
Outdated
|
|
||
| def test_list_zones(self): | ||
| zones = CLIENT.list_zones() | ||
| self.assertEqual(sorted(zones), list(EXPECTED_ZONES)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Hmm, I don't get the Travis failure: we should be skipping system-tests for PRs, shouldn't we? |
Contributor
Author
|
The Travis failure is my fault. I had to re-run the job before I remembered how things work. |
- Using sorted() zone comparison - Creating global CLIENT and CLUSTER at run-time rather than at import-time
dhermes
force-pushed
the
bigtable-basis-sys-test
branch
from
0134f63 to
b223311
Compare
Contributor
Author
|
@tseaver PTAL |
Contributor
|
LGTM. |
dhermes
added a commit
that referenced
this pull request
Feb 23, 2016
Introducing basic system test for Bigtable.
Contributor
Author
|
Arrrg! I committed a |
Contributor
|
Nobody is perfect. |
Contributor
Author
|
Lulz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.