Skip to content

Adding HappyBase Connection.create_table(). #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Feb 24, 2016
Merged

Adding HappyBase Connection.create_table(). #1502

dhermes merged 1 commit into from
Feb 24, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 19, 2016

@tseaver sorry #1501 got closed. I did a git push -f after rebase-ing and it just pushed the HEAD of master (which GitHub interpreted as a delete).

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 19, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2016
dhermes
dhermes reviewed Feb 19, 2016
View reviewed changes
gcloud/bigtable/happybase/connection.py
family options as the values. The options can be among
* :class:`dict`
* :class:`.GarbageCollectionRule`

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Feb 20, 2016

Do all the possible options (dict keys) control only garbage collection?

@dhermes
Copy link
Contributor Author

dhermes commented Feb 20, 2016

The only fields for a table (other than a name) are the GC rules. So the keys of families the dictionary (the one that gets passed to create_table) are the names of the column families (as strings) and then the values specify the configuration for each table.

You're right in wondering though. I'd imagine if at some point the Thrift/HBase table settings

max_versions
compression
in_memory
bloom_filter_type
bloom_filter_vector_size
bloom_filter_nb_hashes
block_cache_enabled
time_to_live

then we'd have a re-design on our hands.

@dhermes dhermes closed this Feb 20, 2016
@dhermes dhermes force-pushed the happybase-create-table branch from 10d0ea4 to 91be693 Compare February 20, 2016 00:22
@dhermes
Copy link
Contributor Author

dhermes commented Feb 20, 2016

How big of a n00b am I! I closed this by accident (from the command line) the exact same way I closed #1501.

@dhermes dhermes reopened this Feb 20, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Feb 20, 2016

@tseaver Does my explanation make sense?

@tseaver tseaver mentioned this pull request Feb 22, 2016
Merged
@dhermes dhermes assigned theacodes and unassigned tseaver Feb 22, 2016
theacodes
theacodes reviewed Feb 23, 2016
View reviewed changes
gcloud/bigtable/happybase/connection.py Outdated
result = option
if isinstance(result, dict):
if not set(result.keys()) <= set(['max_versions', 'time_to_live']):
raise ValueError('Cloud Bigtable only supports max_versions and '

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes force-pushed the happybase-create-table branch from c988088 to 35b5e8d Compare February 24, 2016 16:48
@dhermes
Copy link
Contributor Author

dhermes commented Feb 24, 2016

@jonparrott I changed the exception to a warning in _parse_family_option. Still waiting on the atomicity / rollback question.

@theacodes
Copy link
Contributor

theacodes commented Feb 24, 2016

LGTM, barring the question about atomicity.

(don't forget to squash)

@dhermes
Copy link
Contributor Author

dhermes commented Feb 24, 2016

OK. Will squash and merge and file an issue to follow up.

@theacodes
Copy link
Contributor

theacodes commented Feb 24, 2016

SGTM.

@dhermes dhermes mentioned this pull request Feb 24, 2016
Closed
@dhermes dhermes force-pushed the happybase-create-table branch from 35b5e8d to c001fb9 Compare February 24, 2016 17:36
dhermes added a commit that referenced this pull request Feb 24, 2016
@dhermes
Merge pull request #1502 from dhermes/happybase-create-table
8e03b0d 
Adding HappyBase Connection.create_table().
@dhermes dhermes merged commit 8e03b0d into googleapis:master Feb 24, 2016
@dhermes dhermes deleted the happybase-create-table branch February 24, 2016 17:40
@theacodes theacodes mentioned this pull request Mar 4, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 26, 2025
@BigTailWolf
chore: update token (#1502)
51d84fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theacodes theacodes

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @tseaver @theacodes @googlebot