Librarian generate pull request: 20250911T193301Z#14418
Librarian generate pull request: 20250911T193301Z#14418cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Conversation
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
LGTM. The diff looks identical to https://github.com/googleapis/google-cloud-python/pull/14373/files
.librarian/state.yaml
Outdated
| @@ -1,23 +1,24 @@ | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest | |||
| libraries: | |||
| - id: google-cloud-dlp | |||
There was a problem hiding this comment.
Hmm our indentation isn't correct for the previous state.yaml. @parthea do we want to update the script that is used to create /update this state.yaml?
There was a problem hiding this comment.
Can we consider this non-blocking and file a bug to follow up?
There was a problem hiding this comment.
I filed googleapis/librarian#2073 to follow up on this
There was a problem hiding this comment.
The formatting was fixed in #14419 by manually running yamlfmt. We'll close this PR and open a new one as there are conflicts in this PR
4 participants
This pull request is generated with proto changes between
googleapis/googleapis@d300b15
(exclusive) and
googleapis/googleapis@2585041
(inclusive).
Librarian Version: not available
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest
BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
feat: [google-cloud-dlp] add LocationSupport,Domain,DocumentFallbackLocation
docs: minor doc revision
PiperOrigin-RevId: 804670680
Source-link: googleapis/googleapis@2585041
END_NESTED_COMMIT
END_COMMIT_OVERRIDE