Use runtime specific topic names in Pub/Sub system tests. #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
Our merge build success has been about 50% recently, with all failures caused by system test failures:
|
dhermes
changed the title
Contributor
Author
|
@tseaver PTAL |
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 20, 2016
Use runtime specific topic names in Pub/Sub system tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1363.
@tseaver Note #1370 does the same for
datastore. Should we do the same forstorageandbigquery? At the very least we should re-visit retries (especially for doing a "clean up everything" intearDownModule) so that our system tests don't leave resources around.