Skip to content

fix: Allow protobuf 6.x #13637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 7 commits into from
Mar 11, 2025
Merged

fix: Allow protobuf 6.x #13637

parthea merged 7 commits into from
Mar 11, 2025

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 10, 2025 •
edited
Loading

Apply changes from googleapis/gapic-generator-python#2352 and googleapis/gapic-generator-python#2347 to 4 packages containing protobuf stubs which are not automatically generated using gapic-generator-python

BEGIN_COMMIT_OVERRIDE
fix: Allow protobuf 6.x
fix: resolve issue where pre-release versions of dependencies are installed
END_COMMIT_OVERRIDE

@parthea
Copy link
Contributor Author

parthea commented Mar 10, 2025 •
edited
Loading

presubmit core_deps_from_source failed https://github.com/googleapis/google-cloud-python/actions/runs/13775554603/job/38523909038

~/work/google-cloud-python/google-cloud-python/packages/google-cloud-access-context-manager ~/work/google-cloud-python/google-cloud-python
nox > Error while collecting sessions.
nox > Sessions not found: core_deps_from_source

This was fixed by 346097d

@parthea parthea marked this pull request as ready for review March 10, 2025 22:04
@parthea parthea requested a review from a team as a code owner March 10, 2025 22:04
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2025
vchudnov-g
vchudnov-g reviewed Mar 10, 2025
View reviewed changes
@parthea parthea mentioned this pull request Mar 11, 2025
Merged
@parthea parthea force-pushed the allow-protobuf-6 branch 5 times, most recently from 56340ed to 62cf867 Compare March 11, 2025 14:17
vchudnov-g
vchudnov-g approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One non-trivial (but still minor) comment about avoiding the try/catch.

@parthea @vchudnov-g
Address review feedback
7256758 
Co-authored-by: Victor Chudnovsky <[email protected]>
@parthea parthea enabled auto-merge (squash) March 11, 2025 18:46
@parthea parthea disabled auto-merge March 11, 2025 18:46
@parthea parthea enabled auto-merge (squash) March 11, 2025 18:47
@parthea parthea merged commit b4d4551 into main Mar 11, 2025
20 checks passed
@parthea parthea deleted the allow-protobuf-6 branch March 11, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @vchudnov-g