Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 6, 2016

Relates to #1123, but this has been a long time coming. We can ditch a no longer needed optimization.

@tseaver I verified what would actually be stored in the pip cache, especially when there was no .tox environment and it seems to do what we want. You can see the new things needed / old things re-used in:
https://github.com/dhermes/gcloud-python/commits/tox-with-local-cache

@dhermes dhermes added the testing label Jan 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2016
@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2016

YAY! LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

Haha. It was a relief when I realized it could be done.

I needed to do "science" to convince myself it was all good.

dhermes added a commit that referenced this pull request Jan 7, 2016
Removing use of wheelhouse and relying on Travis caching.
@dhermes dhermes merged commit e328d50 into googleapis:master Jan 7, 2016
@dhermes dhermes deleted the use-travis-caching branch January 7, 2016 21:13
parthea added a commit that referenced this pull request Nov 24, 2025
* Chore: update setup.py to new standards

* added end block

* changed required python version

* Edited golden files

* Edited ads-templates setup.py

* added missing commas to setup.py

* changed classifiers for ads-template setup.py

* changed ads-templates setup.py

* Reverted ads-template changes

* Added templeted version and updated protobuf

* added package_root

* Updated golden test files

* Revert "added package_root"

This reverts commit b8ce6142048b2c51f923948aa6ddb007bde50b51.

* Revert "Updated golden test files"

This reverts commit ba37d1342853745471932f2157fa5e385598c498.

* updated setup.py

* Updated Golden files

* added version to __init__.py

* updated api-core dependency

* updated setup.py to match golden

* Changed version.py path to be set automatically

* added version import into _base.py.j2

* changed version import placement

* added changes from incremental-changes-setup-py

* moved constraints file

* updated golden files

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants