Skip to content

chore(migration): Migrate code from googleapis/python-access-context-manager into packages/google-cloud-access-context-manager#13425

Merged
parthea merged 161 commits intomainfrom
migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate
Jan 13, 2025
Merged

chore(migration): Migrate code from googleapis/python-access-context-manager into packages/google-cloud-access-context-manager#13425
parthea merged 161 commits intomainfrom
migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Jan 10, 2025

See #10887.

This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.

busunkim96 and others added 30 commits May 7, 2020 20:38
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/008ce5bf-87d6-4df6-a516-9e6d6ecebea4/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@41a4e56
Source-Link: googleapis/synthtool@f15b57c
Source-Author: Bu Sun Kim <[email protected]>
Source-Date: Wed Feb 17 14:10:46 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: d17674372e27fb8f23013935e794aa37502071aa
Source-Link: googleapis/synthtool@d176743
Uncomment `generate_protos` and clone `api-common-protos` inside the session so it can be run in autosynth.

Fixes #27  🦕

Verify locally by doing `nox -s generate_protos` (no additional setup should be required)
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: prevent normalization of semver versioning

* chore: update workaround to make sic work
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/860fdaa7-9560-4476-817f-d4f818ae9a94/targets

- [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: googleapis/synthtool@043cc62
Source-Link: googleapis/synthtool@721339a
Source-Link: googleapis/synthtool@0a071b3
Source-Link: googleapis/synthtool@5b5bf6d
Co-authored-by: google-cloud-policy-bot[bot] <80869356+google-cloud-policy-bot[bot]@users.noreply.github.com>
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:4c981a6b6f2b8914a448d7b3a01688365be03e3ed26dfee399a6aa77fb112eaa

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:0856ca711da1fd5ec9d6d7da6c50aa0bbf550fb94acb47b55159a640791987bf
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:c66ba3c8d7bc8566f47df841f98cd0097b28fff0b1864c86f5817f4c8c3e8600
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce
release-please Bot and others added 8 commits August 19, 2024 08:50
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
Source-Link: googleapis/synthtool@71a7297
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: remove pb2 file generation during post processing step

* chore: remove obsolete proto files
* chore: remove pb2 file generation during post processing step

* chore: remove obsolete proto files

* chore: add generation of pb2 files via owlbot/bazel
…-manager/main' into migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate
@parthea parthea requested a review from a team January 10, 2025 16:20
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jan 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@parthea parthea self-assigned this Jan 10, 2025
@parthea parthea removed their assignment Jan 10, 2025
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2025
"library_type": "GAPIC_AUTO",
"repo": "googleapis/google-cloud-python",
"distribution_name": "google-cloud-access-context-manager",
"default_version": "apiVersion",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiVersion is a replacement string, right? At what point does that get replaced with the right version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiVersion won't be replaced for this API because there is no default import. IOW, it's a no-op. This is the same that we have in templates here and for other APIs which do not have a default import such as this one.

google.identity.accesscontextmanager.type
=========================================

.. automodule:: google.identity.accesscontextmanager.type
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of these type.rst files used to have these lines ending in ….type.XXXX_pb2, but now they're truncated to end in ….type. I take it this is expected?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is intended. For now the docs for pb2.py files are not meaningful at the moment. We may use pb2.pyi files instead for docs. b/375167345 is the tracking bug to improve docs in pb2.pyi. The protobuf team has indicated that docs (comments) won't be added to pb2.py files.

@parthea parthea merged commit ec84f53 into main Jan 13, 2025
@parthea parthea deleted the migration.python-access-context-manager.repo.stats.2025-01-10.16-06-17.migrate branch January 13, 2025 16:27
parthea added a commit that referenced this pull request Jan 16, 2025
…config action (#13436)

The Github Action that updates the [release please
configuration](https://github.com/googleapis/google-cloud-python/blob/main/.github/workflows/configure_release_please.yml)
recently started failing after PRs #13425, #13426 and #13427 were
merged. The reason is that the action expects packages to have a file
called `gapic_version.py`, however these packages do not. This PR
updates the release please configuration script to exclude packages
which do not have this file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants