Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 31, 2015

These links were valid in v1beta2 but when the upgrade to
v1 occurred they started to give 404s. Fixes #1211.

Replaced mostly with

git grep -l v1beta2 -- gcloud/pubsub | xargs sed -i s/v1beta2/v1/g
git grep -l 'v1/projects/' -- gcloud/pubsub | \
    xargs sed -i 's/v1\/projects\//v1\/projects\./g'

but manually replaced

/pubsub/reference/rest/v1beta2/projects/topics/subscriptions/list
   -> /pubsub/reference/rest/v1/projects.topics.subscriptions/list

/pubsub/reference/rest/google/pubsub/v1beta2/PubsubMessage
   -> /pubsub/reference/rest/v1/PubsubMessage

after the fact.

These links were valid in v1beta2 but when the upgrade to
v1 occurred they started to give 404s. Fixes googleapis#1211.

Replace mostly with

```
git grep -l v1beta2 -- gcloud/pubsub | xargs sed -i s/v1beta2/v1/g
git grep -l 'v1/projects/' -- gcloud/pubsub | \
    xargs sed -i 's/v1\/projects\//v1\/projects\./g'
```

but manually replaced

```
/pubsub/reference/rest/v1beta2/projects/topics/subscriptions/list
   -> /pubsub/reference/rest/v1/projects.topics.subscriptions/list

/pubsub/reference/rest/google/pubsub/v1beta2/PubsubMessage
   -> /pubsub/reference/rest/v1/PubsubMessage
```

after the fact.
@dhermes dhermes added docs api: pubsub Issues related to the Pub/Sub API. labels Dec 31, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 31, 2015
@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2016

LGTM

dhermes added a commit that referenced this pull request Jan 7, 2016
Fixing broken links in Pub/Sub docs.
@dhermes dhermes merged commit 138fd2c into googleapis:master Jan 7, 2016
@dhermes dhermes deleted the fix-1211 branch January 7, 2016 19:44
parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
* feat: adding meta header for trust boundary

* fixing lint

* adding trust_boundary parameter for 3PI init

* change inject header to kebab case and the value to a reasonable value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants