Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 22, 2015

@tseaver I promise I'm not crazy, I originally noticed that the .proto files were executable when moving things around for v1beta3 datastore changes.


@stephenplusplus @callmehiphop Any idea why the docs resources (which were likely just copied from gcloud-node) have the executable bits set? Should I leave them in place?


Can verify which files had the bit set with:

ls -alFG $(git ls-files) | grep -e '*$'

After this change it leaves

scripts/custom_pip_install.sh*
scripts/merge.sh*
scripts/pep8_on_repo.sh*
scripts/run_system_tests.sh*
scripts/update_docs.sh*
scripts/update_wheels_project.sh*

which all should be executable. We could probably also make our system test runner executable if we felt we needed it.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2015
@stephenplusplus
Copy link

I'm not sure how they ended up being 755, but 644 is the right way to go.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 22, 2015

👍 Thanks

@tseaver
Copy link
Contributor

tseaver commented Dec 22, 2015

LGTM

dhermes added a commit that referenced this pull request Dec 22, 2015
Removing executable bit from non-executable files.
@dhermes dhermes merged commit 56218ef into googleapis:master Dec 22, 2015
@dhermes dhermes deleted the remove-executable-bits branch December 22, 2015 04:54
parthea pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants