Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 19, 2015

For creating a Cluster object from a protobuf cluster returned from the API.

Also adding a helper for making sure properties are set on a protobuf object.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Nov 19, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2015

This comment was marked as spam.

For creating a Cluster object from a protobuf
cluster returned from the API.

Also adding a helper for making sure properties are
set on a protobuf object.
@dhermes dhermes force-pushed the bigtable-cluster-from-pb branch from 48dce46 to 083e738 Compare November 20, 2015 19:15
@dhermes
Copy link
Contributor Author

dhermes commented Nov 20, 2015

@tseaver PTAL. I just implemented _get_pb_property_value (no YAGNI) and I updated the HasField() note to reflect the docs you pointed to (i.e. it doesn't work in proto3 for non-message fields).

@tseaver
Copy link
Contributor

tseaver commented Nov 20, 2015

LGTM

dhermes added a commit that referenced this pull request Nov 20, 2015
Adding Bigtable Cluster.from_pb factory.
@dhermes dhermes merged commit 21101e0 into googleapis:master Nov 20, 2015
@dhermes dhermes deleted the bigtable-cluster-from-pb branch November 20, 2015 19:30
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants