Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 19, 2015

Uses #1189 as a base.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2015
@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2015

Why remove the # Some systems use a single '*' instead of '*/*'. part?

@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2015

LMK when you've rebased after the merge

@tseaver
Copy link
Contributor Author

tseaver commented Oct 23, 2015

Why remove the # Some systems use a single '' instead of '/*'. part?

Because the calling function already raises an error if the pattern has no slash.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 23, 2015

Rebased after merge of #1186.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2015

LGTM

I'll wait for the next rebase ping

tseaver added a commit that referenced this pull request Oct 25, 2015
@tseaver tseaver merged commit 1a78ec9 into googleapis:master Oct 25, 2015
@tseaver tseaver deleted the coverage-gcloud__apitools_util branch October 25, 2015 15:19
parthea added a commit that referenced this pull request Nov 22, 2025
- [ ] Regenerate this pull request now.

BEGIN_COMMIT_OVERRIDE
feat: add PeerInfo proto in Bigtable API 
fix: Add ReadRows/SampleRowKeys bindings for materialized views
fix: Deprecate credentials_file argument
feat: Add Type API updates needed to support structured keys in
materialized views
feat: Add encodings for STRUCT and the Timestamp type
END_COMMIT_OVERRIDE


PiperOrigin-RevId: 829585900

Source-Link:
googleapis/googleapis@1b5f863

Source-Link:
googleapis/googleapis-gen@1a69287
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWE2OTI4NzUwMDNlMjc1NDcyOWRjMmE0Y2NhODgwNTUwNTFkMmFhZSJ9

BEGIN_NESTED_COMMIT
fix: Add ReadRows/SampleRowKeys bindings for materialized views


fix: Deprecate credentials_file argument
chore: Update gapic-generator-python to 1.28.0

PiperOrigin-RevId: 816753840

Source-Link:
googleapis/googleapis@d06cf27

Source-Link:
googleapis/googleapis-gen@a524e73
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTUyNGU3MzEwODgyYmJiOTliZmUxMzk5YjE4YmVkMzI4OTc5MjExYyJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Type API updates needed to support structured keys in
materialized views
feat: Add encodings for STRUCT and the Timestamp type

PiperOrigin-RevId: 805031861

Source-Link:
googleapis/googleapis@6d1dca2

Source-Link:
googleapis/googleapis-gen@ecd9d88
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWNkOWQ4ODYwYmFlOGJiMzdiNDUyYmZjNmVlZmJkZDIyZDAyOGYwOSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: Update gapic-generator-python to 1.26.2
PiperOrigin-RevId: 802200836

Source-Link:
googleapis/googleapis@d300b15

Source-Link:
googleapis/googleapis-gen@a1ff0ae
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTFmZjBhZTcyZGRjYjY4YTI1OTIxNWQ4Yzc3NjYxZTJjZGJiOWIwMiJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: update Python generator version to 1.25.1
PiperOrigin-RevId: 800535761

Source-Link:
googleapis/googleapis@4cf1f99

Source-Link:
googleapis/googleapis-gen@133d25b
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTMzZDI1YjY4ZTcxMjExNmUxYzVkYzcxZmMzZWIzYzVlNzE3MDIyYSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: Add ReadRows/SampleRowKeys bindings for materialized views
PiperOrigin-RevId: 793800781

Source-Link:
googleapis/googleapis@fe06a49

Source-Link:
googleapis/googleapis-gen@c4550f6
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ1NTBmNjA3MjVkYzRjMDdhZGZlNjhjZWUwYWM3MmViNGE1YjFiYiJ9
END_NESTED_COMMIT

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants