Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 19, 2015

Towards #1186.

Subsequent work to include:

  • From-scratch unit test coverage -> 100%.
  • Renamings to match coding standards.
  • Full lint compliance.
  • Folding in the current gcloud.storage.batch implementation.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. packaging hygiene labels Oct 19, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2015
@dhermes
Copy link
Contributor

dhermes commented Oct 20, 2015

I'll try to get to these tonight if I can spare a few minutes. I'm 100% occupied during the day (9am-6pm).

@tseaver
Copy link
Contributor Author

tseaver commented Oct 20, 2015

No worries. This is slog-work, and I've got at least four more hours of it today (coverage for the gcloud._apitools.transfer module). Then cleanups, etc. are likely to keep me busy all week.

@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2015

"Scrape in six used modules from apitools." brought them in with no changes?

@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2015

LGTM assuming the answer to my question above is yes

@tseaver
Copy link
Contributor Author

tseaver commented Oct 23, 2015

d60a679 really did just copy them in. The remaining commits are the minimum to get the code usable / used within gcloud.storage:

  • e4ab851 rewrites imports from apitools.base.py -> gcloud._apitools.
  • d2e4f99 updates gcloud.storage to use the forked code.
  • b8b2766 and ad1ab44 turn off coverage / lint on the forked code until we get done with cleanups.

tseaver added a commit that referenced this pull request Oct 23, 2015
…itools

#1186: Revendor apitools as 'gcloud._apitools'
@tseaver tseaver merged commit ddb8d20 into googleapis:master Oct 23, 2015
@tseaver tseaver deleted the revendor_apitools_as_gcloud__apitools branch October 23, 2015 20:26
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
* feat: Introduce a way to provide scopes granted by user

* nits

* add rt

* update rt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants