Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 12, 2015

See #1054.

@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Aug 12, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2015

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Aug 12, 2015

LGTM but I'm still not sure if Connect.run_query should remain unchanged.

tseaver added a commit that referenced this pull request Aug 12, 2015
#1054: Set query cursor to 'None' when returned as empty string.
@tseaver tseaver merged commit e1913fa into googleapis:master Aug 12, 2015
@tseaver tseaver deleted the 1054-nullify_empty_query_cursor branch August 12, 2015 20:21
@dhermes
Copy link
Contributor

dhermes commented Aug 12, 2015

@tseaver I was hoping we could discuss my concern before merging. Should I have held off the LGTM to make it clearer?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 13, 2015

Sorry -- I did take the LGTM as a green light. Maybe re-open #1054 with your extra concern?

gcf-owl-bot bot added a commit that referenced this pull request Jul 9, 2025
This partially reverses PR #1046
Source-Link: googleapis/googleapis@2b00aed

Source-Link: googleapis/googleapis-gen@d9fa2cd
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJpZ3F1ZXJ5LWRhdGF0cmFuc2Zlci8uT3dsQm90LnlhbWwiLCJoIjoiZDlmYTJjZDFjNDE5NzFhZmMzNWNjZjk1YWY4YzAxOTA0YTJhMGNiZSJ9
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXF1b3Rhcy8uT3dsQm90LnlhbWwiLCJoIjoiZDlmYTJjZDFjNDE5NzFhZmMzNWNjZjk1YWY4YzAxOTA0YTJhMGNiZSJ9
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXJldGFpbC8uT3dsQm90LnlhbWwiLCJoIjoiZDlmYTJjZDFjNDE5NzFhZmMzNWNjZjk1YWY4YzAxOTA0YTJhMGNiZSJ9
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXNlY3VyaXR5Y2VudGVyLy5Pd2xCb3QueWFtbCIsImgiOiJkOWZhMmNkMWM0MTk3MWFmYzM1Y2NmOTVhZjhjMDE5MDRhMmEwY2JlIn0=
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLW1hcHMtZmxlZXRlbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6ImQ5ZmEyY2QxYzQxOTcxYWZjMzVjY2Y5NWFmOGMwMTkwNGEyYTBjYmUifQ==
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@223f39e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8244c1253becbaa533f48724a6348e4b92a10df4b4dfb66d87e615e633059bdf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <[email protected]>
parthea pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants