Bringing all environment variables into a single place. #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can give a quick overview of all environment variables used.
googlebot
added
the
cla: yes
Contributor
|
I don't object to centralizing them; ISTM that if we do so, it would be to make them "non-private", so maybe remove the leading underscore on the module name / variable names?? |
Contributor
Author
|
@tseaver What about also axing |
Contributor
|
I was thinking to point to it from user-facing docs on configuring |
Contributor
Author
|
SGTM |
Contributor
Author
|
@tseaver PTAL |
Contributor
|
@dhermes I don't see any new commits. |
Also renaming all variables in the file to drop the `_ENV_VAR_NAME` post-fix and the leading underscore.
Contributor
Author
|
@tseaver D'oh! #FAIL by me. Actually pushed the commit now. |
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jul 23, 2015
Bringing all environment variables into a single place.
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
* feat: add fields and the BackupType proto for Hot Backups docs: clarify comments and fix typos PiperOrigin-RevId: 658791576 Source-Link: googleapis/googleapis@c93b54f Source-Link: googleapis/googleapis-gen@e52ba38 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTUyYmEzOGE5NWE4MmY3NTg4ZDBkZDNhMjI4NGM5ODg1MGRhYjllMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
I found this change makes it a bit easier to implement #960.
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we can give a quick overview of all environment variables used.
Inspired by the
gcloud-*wide discussion of env. vars. I'm not sure if this is worth doing, so @tseaver feel free to shoot this down./cc @jgeewax