After some spelunking, started from reports like #5909 where users have reported hanging on requests, I have uncovered that we don't have read or connect timeouts for our default requests session on storage.
I think adding a connect timeout is warranted for sure, and possible having a read timeout, makes sense? urllib3 via request.session is what is controlling that which by default doesn't specify anything. https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#module-urllib3.util.timeout
I propose a connection timeout of 1 minute. I am less sure of read timeout as that would vary a bit between crud and streaming operations.
cc: @frankyn
After some spelunking, started from reports like #5909 where users have reported hanging on requests, I have uncovered that we don't have read or connect timeouts for our default requests session on storage.
I think adding a connect timeout is warranted for sure, and possible having a read timeout, makes sense?
urllib3viarequest.sessionis what is controlling that which by default doesn't specify anything. https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#module-urllib3.util.timeoutI propose a connection timeout of 1 minute. I am less sure of read timeout as that would vary a bit between crud and streaming operations.
cc: @frankyn