Skip to content

Commit de6fd48

Browse files
committed
Exercise 'storage.batch.Batch' during bucket cleanup.
1 parent 0fd7495 commit de6fd48

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

regression/storage.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
from gcloud import storage
2222
from gcloud.storage._helpers import _base64_md5hash
2323
from gcloud.storage import _implicit_environ
24+
from gcloud.storage.batch import Batch
2425

2526

2627
HTTP = httplib2.Http()
@@ -52,15 +53,16 @@ def setUp(self):
5253
self.case_buckets_to_delete = []
5354

5455
def tearDown(self):
55-
for bucket in self.case_buckets_to_delete:
56-
bucket.delete()
56+
with Batch(CONNECTION) as batch:
57+
for bucket_name in self.case_buckets_to_delete:
58+
batch.get_bucket(bucket_name).delete()
5759

5860
def test_create_bucket(self):
5961
new_bucket_name = 'a-new-bucket'
6062
self.assertRaises(exceptions.NotFound,
6163
CONNECTION.get_bucket, new_bucket_name)
6264
created = CONNECTION.create_bucket(new_bucket_name)
63-
self.case_buckets_to_delete.append(created)
65+
self.case_buckets_to_delete.append(new_bucket_name)
6466
self.assertEqual(created.name, new_bucket_name)
6567

6668
def test_get_buckets(self):
@@ -72,7 +74,7 @@ def test_get_buckets(self):
7274
created_buckets = []
7375
for bucket_name in buckets_to_create:
7476
bucket = CONNECTION.create_bucket(bucket_name)
75-
self.case_buckets_to_delete.append(bucket)
77+
self.case_buckets_to_delete.append(bucket_name)
7678

7779
# Retrieve the buckets.
7880
all_buckets = CONNECTION.get_all_buckets()

0 commit comments

Comments
 (0)