Skip to content

Commit 9bc46c4

Browse files
committed
Don't pass 'fields' query parm to subscription GET.
Work around #799 (leaving open while @tmatsuo investigates).
1 parent f3c3543 commit 9bc46c4

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

gcloud/pubsub/subscription.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ def exists(self):
7474
"""
7575
conn = self.topic.connection
7676
try:
77-
conn.api_request(method='GET',
78-
path=self.path,
79-
query_params={'fields': 'name'})
77+
conn.api_request(method='GET', path=self.path)
8078
except NotFound:
8179
return False
8280
else:

gcloud/pubsub/test_subscription.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def test_exists_miss(self):
9595
req = conn._requested[0]
9696
self.assertEqual(req['method'], 'GET')
9797
self.assertEqual(req['path'], '/%s' % SUB_PATH)
98-
self.assertEqual(req['query_params'], {'fields': 'name'})
98+
self.assertEqual(req.get('query_params'), None)
9999

100100
def test_exists_hit(self):
101101
PROJECT = 'PROJECT'
@@ -111,7 +111,7 @@ def test_exists_hit(self):
111111
req = conn._requested[0]
112112
self.assertEqual(req['method'], 'GET')
113113
self.assertEqual(req['path'], '/%s' % SUB_PATH)
114-
self.assertEqual(req['query_params'], {'fields': 'name'})
114+
self.assertEqual(req.get('query_params'), None)
115115

116116
def test_reload(self):
117117
PROJECT = 'PROJECT'

0 commit comments

Comments
 (0)