Add a regression test for 'pubsub.list_subscriptions()'.

tseaver · tseaver · commit 8ba7e369fcb6 · 2015-04-03T12:27:41.000-04:00
diff --git a/gcloud/pubsub/__init__.py b/gcloud/pubsub/__init__.py
@@ -29,6 +29,7 @@
 from gcloud.connection import get_scoped_connection
 from gcloud.pubsub import _implicit_environ
 from gcloud.pubsub._implicit_environ import get_default_connection
+from gcloud.pubsub.api import list_subscriptions
 from gcloud.pubsub.api import list_topics
 from gcloud.pubsub.connection import Connection
 
diff --git a/regression/pubsub.py b/regression/pubsub.py
@@ -50,7 +50,6 @@ def test_list_topics(self):
             'newer%d' % (1000 * time.time(),),
             'newest%d' % (1000 * time.time(),),
         ]
-        created_topics = []
         for topic_name in topics_to_create:
             topic = Topic(topic_name)
             topic.create()
@@ -59,10 +58,10 @@ def test_list_topics(self):
         # Retrieve the topics.
         all_topics, _ = pubsub.list_topics()
         project_id = pubsub.get_default_project()
-        created_topics = [topic for topic in all_topics
-                          if topic.name in topics_to_create and
-                          topic.project == project_id]
-        self.assertEqual(len(created_topics), len(topics_to_create))
+        created = [topic for topic in all_topics
+                   if topic.name in topics_to_create and
+                   topic.project == project_id]
+        self.assertEqual(len(created), len(topics_to_create))
 
     def test_create_subscription(self):
         TOPIC_NAME = 'subscribe-me'
@@ -78,3 +77,26 @@ def test_create_subscription(self):
         self.assertTrue(subscription.exists())
         self.assertEqual(subscription.name, SUBSCRIPTION_NAME)
         self.assertTrue(subscription.topic is topic)
+
+    def test_list_subscriptions(self):
+        TOPIC_NAME = 'subscribe-me'
+        topic = Topic(TOPIC_NAME)
+        self.assertFalse(topic.exists())
+        topic.create()
+        self.to_delete.append(topic)
+        subscriptions_to_create = [
+            'new%d' % (1000 * time.time(),),
+            'newer%d' % (1000 * time.time(),),
+            'newest%d' % (1000 * time.time(),),
+        ]
+        for subscription_name in subscriptions_to_create:
+            subscription = Subscription(subscription_name, topic)
+            subscription.create()
+            self.to_delete.append(subscription)
+
+        # Retrieve the subscriptions.
+        all_subscriptions, _ = pubsub.list_subscriptions()
+        created = [subscription for subscription in all_subscriptions
+                   if subscription.name in subscriptions_to_create and
+                   subscription.topic.name == TOPIC_NAME]
+        self.assertEqual(len(created), len(subscriptions_to_create))
