Skip to content

Commit 37ad9e2

Browse files
committed
Fix pubsub regression test:
Broken by rename of 'Message.attrs' -> 'attributes'.
1 parent bafb197 commit 37ad9e2

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

gcloud/pubsub/message.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ class Message(object):
3535
def __init__(self, data, message_id, attributes=None):
3636
self.data = data
3737
self.message_id = message_id
38-
self._attrs = attributes
38+
self._attributes = attributes
3939

4040
@property
41-
def attrs(self):
41+
def attributes(self):
4242
"""Lazily-constructed attribute dictionary"""
43-
if self._attrs is None:
44-
self._attrs = {}
45-
return self._attrs
43+
if self._attributes is None:
44+
self._attributes = {}
45+
return self._attributes
4646

4747
@classmethod
4848
def from_api_repr(cls, api_repr):

gcloud/pubsub/test_message.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,25 @@ def _getTargetClass(self):
2424
def _makeOne(self, *args, **kw):
2525
return self._getTargetClass()(*args, **kw)
2626

27-
def test_ctor_no_attrs(self):
27+
def test_ctor_no_attributes(self):
2828
DATA = b'DEADBEEF'
2929
MESSAGE_ID = b'12345'
3030
message = self._makeOne(data=DATA, message_id=MESSAGE_ID)
3131
self.assertEqual(message.data, DATA)
3232
self.assertEqual(message.message_id, MESSAGE_ID)
33-
self.assertEqual(message.attrs, {})
33+
self.assertEqual(message.attributes, {})
3434

35-
def test_ctor_w_attrs(self):
35+
def test_ctor_w_attributes(self):
3636
DATA = b'DEADBEEF'
3737
MESSAGE_ID = b'12345'
3838
ATTRS = {'a': 'b'}
3939
message = self._makeOne(data=DATA, message_id=MESSAGE_ID,
4040
attributes=ATTRS)
4141
self.assertEqual(message.data, DATA)
4242
self.assertEqual(message.message_id, MESSAGE_ID)
43-
self.assertEqual(message.attrs, ATTRS)
43+
self.assertEqual(message.attributes, ATTRS)
4444

45-
def test_from_api_repr_no_attrs(self):
45+
def test_from_api_repr_no_attributes(self):
4646
from base64 import b64encode as b64
4747
DATA = b'DEADBEEF'
4848
B64_DATA = b64(DATA)
@@ -51,9 +51,9 @@ def test_from_api_repr_no_attrs(self):
5151
message = self._getTargetClass().from_api_repr(api_repr)
5252
self.assertEqual(message.data, DATA)
5353
self.assertEqual(message.message_id, MESSAGE_ID)
54-
self.assertEqual(message.attrs, {})
54+
self.assertEqual(message.attributes, {})
5555

56-
def test_from_api_repr_w_attrs(self):
56+
def test_from_api_repr_w_attributes(self):
5757
from base64 import b64encode as b64
5858
DATA = b'DEADBEEF'
5959
B64_DATA = b64(DATA)
@@ -65,4 +65,4 @@ def test_from_api_repr_w_attrs(self):
6565
message = self._getTargetClass().from_api_repr(api_repr)
6666
self.assertEqual(message.data, DATA)
6767
self.assertEqual(message.message_id, MESSAGE_ID)
68-
self.assertEqual(message.attrs, ATTRS)
68+
self.assertEqual(message.attributes, ATTRS)

gcloud/pubsub/test_subscription.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ def test_pull_wo_return_immediately_wo_max_messages(self):
269269
self.assertTrue(isinstance(message, Message))
270270
self.assertEqual(message.data, PAYLOAD)
271271
self.assertEqual(message.message_id, MSG_ID)
272-
self.assertEqual(message.attrs, {})
272+
self.assertEqual(message.attributes, {})
273273
self.assertEqual(len(conn._requested), 1)
274274
req = conn._requested[0]
275275
self.assertEqual(req['method'], 'POST')
@@ -300,7 +300,7 @@ def test_pull_w_return_immediately_w_max_messages(self):
300300
self.assertTrue(isinstance(message, Message))
301301
self.assertEqual(message.data, PAYLOAD)
302302
self.assertEqual(message.message_id, MSG_ID)
303-
self.assertEqual(message.attrs, {'a': 'b'})
303+
self.assertEqual(message.attributes, {'a': 'b'})
304304
self.assertEqual(len(conn._requested), 1)
305305
req = conn._requested[0]
306306
self.assertEqual(req['method'], 'POST')

0 commit comments

Comments
 (0)