#295 let entity save accept null value for attribute

lucemia · lucemia · commit 375382154060 · 2014-10-27T12:17:03.000+08:00
diff --git a/gcloud/datastore/helpers.py b/gcloud/datastore/helpers.py
@@ -222,6 +222,9 @@ def _set_protobuf_value(value_pb, val):
                :class:`gcloud.datastore.entity.Entity`,
     :param val: The value to be assigned.
     """
+    if val is None:
+        return
+
     attr, val = _get_protobuf_attribute_and_value(val)
     if attr == 'key_value':
         value_pb.key_value.CopyFrom(val)
diff --git a/gcloud/datastore/test_helpers.py b/gcloud/datastore/test_helpers.py
@@ -361,6 +361,20 @@ def test_key(self):
         value = pb.key_value
         self.assertEqual(value, key.to_protobuf())
 
+    def test_none(self):
+        pb = self._makePB()
+        self._callFUT(pb, None)
+        self.assertEqual(pb.HasField('boolean_value'), False)
+        self.assertEqual(pb.HasField('integer_value'), False)
+        self.assertEqual(pb.HasField('double_value'), False)
+        self.assertEqual(pb.HasField('timestamp_microseconds_value'), False)
+        self.assertEqual(pb.HasField('key_value'), False)
+        self.assertEqual(pb.HasField('blob_key_value'), False)
+        self.assertEqual(pb.HasField('string_value'), False)
+        self.assertEqual(pb.HasField('blob_value'), False)
+        self.assertEqual(pb.HasField('entity_value'), False)
+        self.assertEqual(len(pb.list_value), 0)
+
     def test_bool(self):
         pb = self._makePB()
         self._callFUT(pb, False)
