Skip to content

docs(Compute): update samples to use new surface#7907

Merged
bshaffer merged 1 commit intomainfrom
compute-migrating
Dec 11, 2024
Merged

docs(Compute): update samples to use new surface#7907
bshaffer merged 1 commit intomainfrom
compute-migrating

Conversation

@bshaffer
Copy link
Copy Markdown
Contributor

@bshaffer bshaffer commented Dec 10, 2024

Use new surface clients for compute samples and link to them in the documentation

@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Dec 10, 2024
@bshaffer bshaffer changed the title feat(Compute): update migration mode to MIGRATING chore(Compute): update samples to use new surface Dec 10, 2024
@bshaffer bshaffer changed the title chore(Compute): update samples to use new surface docs(Compute): update samples to use new surface Dec 10, 2024
@bshaffer bshaffer added the next release PRs to be included in the next release label Dec 10, 2024
@bshaffer bshaffer marked this pull request as ready for review December 10, 2024 19:34
@bshaffer bshaffer requested review from a team December 10, 2024 19:34
Copy link
Copy Markdown
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

Separate from this, I think the CODEOWNERS is incorrect as CICD probably shouldn't get tagged for all the things :) but feels like that's a bigger lift figuring out the right teams as I'm guessing from a samples perspective there isn't the equivalent setup right now in googleapis as GoogleCloudPlatform.

@bshaffer bshaffer merged commit e6f8670 into main Dec 11, 2024
@bshaffer bshaffer deleted the compute-migrating branch December 11, 2024 19:21
bshaffer added a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. next release PRs to be included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants