Skip to content

fix(compute): revert proto3_optional, required removal on parent_id (#714)#5113

Merged
dwsupplee merged 4 commits intomainfrom
owl-bot-copy-Compute
Apr 27, 2022
Merged

fix(compute): revert proto3_optional, required removal on parent_id (#714)#5113
dwsupplee merged 4 commits intomainfrom
owl-bot-copy-Compute

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Feb 11, 2022 •
edited
Loading

  • Regenerate this pull request now.

Source-Link: googleapis/googleapis@6b3fdce

Source-Link: https://github.com/googleapis/googleapis-gen/commit/832dbe998878d8619d6b40fe57c6d2cc6e7dc90c
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiODMyZGJlOTk4ODc4ZDg2MTlkNmI0MGZlNTdjNmQyY2M2ZTdkYzkwYyJ9

fix(compute): [Compute] remove proto3_optional from parent_id (#712)
Source-Link: googleapis/googleapis@fd16b6a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d935b9847a1b708ab4e696320ba60ce0341c5d7a
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9

fix(compute): replace missing REQUIRED for parent_id (#711)

Source-Link: googleapis/googleapis@4bb6fd6

Source-Link: https://github.com/googleapis/googleapis-gen/commit/c7d06533be6e2470e36b9f351ae4ff479a47dc53
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYzdkMDY1MzNiZTZlMjQ3MGUzNmI5ZjM1MWFlNGZmNDc5YTQ3ZGM1MyJ9

feat: update compute API to revision 20220322 (#710)

Source-Link: googleapis/googleapis@68ad73b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a581672061b9481c0192de03bbfa3464e0233811
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYTU4MTY3MjA2MWI5NDgxYzAxOTJkZTAzYmJmYTM0NjRlMDIzMzgxMSJ9

fix: fix breaking changes in Compute API (#701)

Source-Link: googleapis/googleapis@272c110

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4c674ff6fdb2ba58efcc4e79cdd8224b6e04da94
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiNGM2NzRmZjZmZGIyYmE1OGVmY2M0ZTc5Y2RkODIyNGI2ZTA0ZGE5NCJ9

feat: update compute API to revision 20220112 (#700)

Source-Link: googleapis/googleapis@249e9a1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/1f2c41bbfe097616ceb1e9fb67872a6bb1dc59d4
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiMWYyYzQxYmJmZTA5NzYxNmNlYjFlOWZiNjc4NzJhNmJiMWRjNTlkNCJ9

@gcf-owl-bot gcf-owl-bot Bot requested review from a team February 11, 2022 01:54
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 11, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
dwsupplee
dwsupplee reviewed Mar 29, 2022
View reviewed changes
Comment thread Compute/src/V1/Gapic/FirewallPoliciesGapicClient.php Outdated
@gcf-owl-bot gcf-owl-bot Bot changed the title feat: [Compute] update compute API to revision 20220112 (#700) feat: update compute API to revision 20220322 (#710) Apr 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 6, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2022
@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot Bot commented Apr 8, 2022

Owl bot is regenerating pull request 5113...
Build name: OThlYTMwMDktODQ1ZC00NDM5LWFjMWMtNDI1N2YzZTA1ODEy

@gcf-owl-bot gcf-owl-bot Bot changed the title feat: update compute API to revision 20220322 (#710) feat: [Compute] update compute API to revision 20220322 (#710) Apr 8, 2022
@gcf-owl-bot gcf-owl-bot Bot force-pushed the owl-bot-copy-Compute branch from 3502340 to 0ad9b24 Compare April 8, 2022 16:12
@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot Bot commented Apr 12, 2022

Owl bot is regenerating pull request 5113...
Build name: NTczZmE1NTktZGY2Yy00MGJlLWI5MDAtYzFmY2NjN2VkNjZj

@gcf-owl-bot gcf-owl-bot Bot changed the title fix(compute): replace missing REQUIRED for parent_id (#711) fix(compute): [Compute] replace missing REQUIRED for parent_id (#711) Apr 12, 2022
@gcf-owl-bot gcf-owl-bot Bot force-pushed the owl-bot-copy-Compute branch from 5a85812 to 158ac85 Compare April 12, 2022 23:43
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@gcf-owl-bot gcf-owl-bot Bot changed the title fix(compute): [Compute] replace missing REQUIRED for parent_id (#711) fix(compute): remove proto3_optional from parent_id (#712) Apr 12, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2022
@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot Bot commented Apr 14, 2022

Owl bot is regenerating pull request 5113...
Build name: NDNlODc3MTAtNzQ0Ni00ZmZlLWJlMmEtNjY1ZGNjMmI3ZTk2

gcf-owl-bot Bot added 2 commits April 14, 2022 19:08
@gcf-owl-bot
fix(compute): remove proto3_optional from parent_id (#712)
0d506b8 
Source-Link: googleapis/googleapis@fd16b6a

Source-Link: googleapis/googleapis-gen@d935b98
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiZDkzNWI5ODQ3YTFiNzA4YWI0ZTY5NjMyMGJhNjBjZTAzNDFjNWQ3YSJ9

fix(compute): replace missing REQUIRED for parent_id (#711)

Source-Link: googleapis/googleapis@4bb6fd6

Source-Link: googleapis/googleapis-gen@c7d0653
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYzdkMDY1MzNiZTZlMjQ3MGUzNmI5ZjM1MWFlNGZmNDc5YTQ3ZGM1MyJ9

feat: update compute API to revision 20220322 (#710)

Source-Link: googleapis/googleapis@68ad73b

Source-Link: googleapis/googleapis-gen@a581672
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYTU4MTY3MjA2MWI5NDgxYzAxOTJkZTAzYmJmYTM0NjRlMDIzMzgxMSJ9

fix: fix breaking changes in Compute API (#701)

Source-Link: googleapis/googleapis@272c110

Source-Link: googleapis/googleapis-gen@4c674ff
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiNGM2NzRmZjZmZGIyYmE1OGVmY2M0ZTc5Y2RkODIyNGI2ZTA0ZGE5NCJ9

feat: update compute API to revision 20220112 (#700)

Source-Link: googleapis/googleapis@249e9a1

Source-Link: googleapis/googleapis-gen@1f2c41b
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiMWYyYzQxYmJmZTA5NzYxNmNlYjFlOWZiNjc4NzJhNmJiMWRjNTlkNCJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
6ff6b4c 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
noahdietz
noahdietz reviewed Apr 19, 2022
View reviewed changes
Comment thread Compute/src/V1/Gapic/FirewallPoliciesGapicClient.php Outdated
@noahdietz
Copy link
Copy Markdown
Contributor

noahdietz commented Apr 25, 2022

@dwsupplee can we merge this now that the breaking changes are resolved and CI is passing (sans Windows)?

@bshaffer
Copy link
Copy Markdown
Contributor

bshaffer commented Apr 25, 2022

I found no BC-breaking issues, and I also ran the roave BC-breaking change detector successfully

@release-please release-please Bot mentioned this pull request Apr 27, 2022
Merged
@bshaffer bshaffer mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer approved these changes

@noahdietz noahdietz noahdietz approved these changes

+1 more reviewer

@dwsupplee dwsupplee dwsupplee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noahdietz @bshaffer @dwsupplee @kokoro-team