Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Resource in the option of message is not included in path template #676

Closed
googleapis/gapic-generator-typescript
#211
Closed
Resource in the option of message is not included in path template#676
googleapis/gapic-generator-typescript
#211
Assignees
alexander-fenster
Labels
🚨This issue needs some love.triage meI really want to be triaged.
@xiaozhenliu-gg5

Description

@xiaozhenliu-gg5
xiaozhenliu-gg5
opened on Jan 24, 2020

For irm API, annotation resource is listed in gapic-yaml, and defined in incidents.proto:

  - name_pattern: projects/{project}/incidents/{incident}/annotations/{annotation}
    entity_name: annotation

message Annotation {
  option (google.api.resource) = {
    type: "irm.googleapis.com/Annotation"
    pattern: "projects/{project}/incidents/{incident}/annotations/{annotation}"
  };
...
}

but we don't catch it as a path_template, now we are just looking for the resource_reference in the field of message:

const resourceReference = fieldDescriptor.options?.['.google.api.resourceReference']

while the option of message itself should be included as well, which is in messagesMap[property].options.['.google.api.resource']

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions