fix: Revert "fix: Do not publish the protos to npm"#8096
Merged
gcf-merge-on-green[bot] merged 1 commit intomainfrom Apr 22, 2026
Merged
fix: Revert "fix: Do not publish the protos to npm"#8096gcf-merge-on-green[bot] merged 1 commit intomainfrom
gcf-merge-on-green[bot] merged 1 commit intomainfrom
Conversation
This reverts commit 816216b.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package.json files across a large number of Google Cloud Node.js client libraries to include the build/protos directory in the published package files. This change ensures that protocol buffer definitions are correctly bundled with the distributed npm packages. I have no feedback to provide as the implementation is consistent across all affected packages.
quirogas
approved these changes
Apr 22, 2026
Contributor
quirogas
left a comment
quirogas
left a comment
There was a problem hiding this comment.
Thank you for reverting this change. For posterity, we are reverting this change because the proto/ directory also contains .js and .ts files, so we have to implement a more granular exclusion to avoid removing those altogether.
for #4820
danieljbruce
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before we merge this PR, let's make sure fewer files are generated.
Impact
Reverses a change that excludes too many files, some of which may be necessary for the client library.