fix(spanner): override gcp-metadata to resolve punycode deprecation#7815
Merged
surbhigarg92 merged 2 commits intomainfrom Mar 23, 2026
Merged
fix(spanner): override gcp-metadata to resolve punycode deprecation#7815surbhigarg92 merged 2 commits intomainfrom
surbhigarg92 merged 2 commits intomainfrom
Conversation
surbhigarg92
changed the title
olavloite
approved these changes
Mar 23, 2026
Contributor
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
Just to be sure: This change does not change the minimum version of Node or any other major components that are required to use this library, right?
Contributor
No. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds overrides for
gcp-metadatato version^7.0.1to resolve Node.js deprecation warnings.Issue
When running on Node.js 22, deep sub-dependencies (transitively imported via
gcp-metadata) trigger the following warning:DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.Solution
Forcing
@google-cloud/spannerto resolvegcp-metadatato^7.0.1ensures that updated versions of internal libraries (e.g.,gaxios) are fetched, correctly bypassing the deprecatedpunycodemodules.Changes
Added package manager overrides in package.json:
"overrides"for npm / yarn workspaces compatibility."pnpm.overrides"for pnpm resolving.BEGIN_COMMIT_OVERRIDE
fix(spanner): override gcp-metadata to resolve punycode deprecation](#7815 (comment))
END_COMMIT_OVERRIDE