Skip to content

ci: release-please to tag pull request number#6338

Merged
sofisl merged 4 commits intogoogleapis:mainfrom
suztomo:patch-1
Jun 2, 2025
Merged

ci: release-please to tag pull request number#6338
sofisl merged 4 commits intogoogleapis:mainfrom
suztomo:patch-1

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented May 5, 2025

This google-cloud-node epository creates multiple Git tags upon one release pull request (commit). Example: #6197

To adopt the new release pipeline based on Git tags, this tagPullRequestNumber creates an additional "release-please-" tag to a release. We'll monitor that tag to trigger the release job.

While this repository config change adds a new tag, I wait the Louhi migration until b/414873255 is resolved.

For maintainers, would you approve and merge this pull request? You may have to temporarily lift OwlBot postprocessor check.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This google-cloud-node epository creates multiple Git tags upon one release pull request (commit). Example: googleapis#6197

To adopt the new release pipeline based on Git tags, this `tagPullRequestNumber` creates an additional "release-please-<pr number>" tag to a release. We'll monitor that tag to trigger the release job.
@suztomo suztomo requested a review from yoshi-approver as a code owner May 5, 2025 16:54
@suztomo suztomo requested a review from a team May 5, 2025 16:54
@suztomo suztomo changed the title Update release-please.yml ci: release-please to tag pull request number May 28, 2025
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented May 28, 2025

b/414873255 has been resolved. Let's resume the work.

@sofisl Would you review this? This change will add a new tag "release-please-" so that Louhi triggers just one job when a release is made for many components.

@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented May 30, 2025

/gcbrun

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jun 2, 2025

The Google Cloud Build says Needs /gcbrun to run latest commit.

@sofisl Can you try again?

@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Jun 2, 2025

/gcbrun

@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Jun 2, 2025

/gcbrun

@sofisl sofisl merged commit 30da234 into googleapis:main Jun 2, 2025
11 checks passed
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jun 2, 2025

Thank you

@suztomo suztomo deleted the patch-1 branch June 2, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants