pubsub: type check input. fixes #500 by stephenplusplus · Pull Request #501 · googleapis/google-cloud-node

stephenplusplus · 2015-04-14T21:14:05Z

Fixes #500

This confirms every message provided to Topic#publish has a data property.

Sign in to view

ryanseys · 2015-04-15T14:38:15Z

LGTM.

…r-message pubsub: type check input. fixes #500

🤖 I have created a release \*beep\* \*boop\* --- ### [2.2.5](https://www.github.com/googleapis/nodejs-redis/compare/v2.2.4...v2.2.5) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#500](https://www.github.com/googleapis/nodejs-redis/issues/500)) ([e19ae5a](https://www.github.com/googleapis/nodejs-redis/commit/e19ae5a3371fba34b0a59f769609e64582e00da4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Wed Aug 12 12:12:29 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5747555f7620113d9a2078a48f4c047a99d31b3e Source-Link: googleapis/synthtool@5747555

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/940354f9-15cd-4361-bbf4-dc9af1426979/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@99c93fe

Fixes #501.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/940354f9-15cd-4361-bbf4-dc9af1426979/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@99c93fe

pubsub: type check input. fixes googleapis#500

b6ba3e9

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2015

stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label Apr 14, 2015

tmatsuo reviewed Apr 14, 2015
View reviewed changes

Comment thread lib/pubsub/topic.js Outdated

This comment was marked as spam.

Sign in to view

check for data property

eef7ce2

stephenplusplus force-pushed the spp--pubsub-publish-error-message branch from 8277608 to eef7ce2 Compare April 15, 2015 14:19

ryanseys added a commit that referenced this pull request Apr 15, 2015

Merge pull request #501 from stephenplusplus/spp--pubsub-publish-erro…

64b6140

…r-message pubsub: type check input. fixes #500

ryanseys merged commit 64b6140 into googleapis:master Apr 15, 2015

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

test(nodejs): remove 15 add 16 (#1322) (#501)

fc09a57

sofisl pushed a commit that referenced this pull request Sep 27, 2022

fix(browser): check for fetch on window (#501)

ab61876

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

test(nodejs): remove 15 add 16 (#1322) (#501)

265ab69

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

test(nodejs): remove 15 add 16 (#1322) (#501)

e0b9e64

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

test(nodejs): remove 15 add 16 (#1322) (#501)

bb4bee9

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl pushed a commit that referenced this pull request Nov 9, 2022

fix(browser): check for fetch on window (#501)

8bc3e26

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

migrate code from googleapis/nodejs-translate #3520

Merged

sofisl pushed a commit that referenced this pull request Nov 10, 2022

chore: remove duplicate mocha config (#501)

9d60ccd

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-container #3543

Merged

4 tasks

sofisl mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-bigquery #7111

Merged

4 tasks

GautamSharda mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-logging-winston #7129

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 3, 2026

chore: update npm scripts and synth.py (#501)

1186ec0

Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.

sofisl mentioned this pull request Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7136

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Feb 4, 2026

docs: update product branding (#501)

cb4fd9f

This was referenced Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7137

Closed

migrate code from googleapis/nodejs-logging-bunyan #7138

Merged

migrate code from googleapis/nodejs-datastore #7148

Closed

sofisl pushed a commit that referenced this pull request Feb 5, 2026

fix: transaction#run overloads' param types correction (#501)

d571934

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Feb 17, 2026

fix: transaction#run overloads' param types correction (#501)

236e277

sofisl mentioned this pull request Feb 17, 2026

migrate code from googleapis/nodejs-datastore #7263

Merged

4 tasks

GautamSharda mentioned this pull request Feb 23, 2026

migrate code from googleapis/nodejs-error-reporting #7294

Closed

sofisl pushed a commit that referenced this pull request Feb 24, 2026

Fix getAll function signature to allow array destructuring (#515)

bdc9f13

Fixes #501.

GautamSharda mentioned this pull request Feb 26, 2026

migrate code from googleapis/nodejs-error-reporting #7308

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Feb 26, 2026

fix(deps): update dependency google-gax to ^0.24.0 (#501)

cfbd336

GautamSharda pushed a commit that referenced this pull request Mar 5, 2026

feat: support apiEndpoint override (#501)

efeeb61

GautamSharda mentioned this pull request Mar 5, 2026

migrate code from googleapis/nodejs-logging #7514

Merged

4 tasks

meltsufin mentioned this pull request Mar 10, 2026

chore: migrate code from googleapis/nodejs-logging #7550

Merged

GautamSharda pushed a commit that referenced this pull request Mar 11, 2026

refactor(ts): enable noImplicitAny for IAM test file (#501)

08c6591

GautamSharda mentioned this pull request Mar 11, 2026

migrate code from googleapis/nodejs-pubsub #7592

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Mar 12, 2026

chore: release 2.2.4 (#501)

a55e40e

GautamSharda mentioned this pull request Mar 12, 2026

migrate code from googleapis/nodejs-common #7597

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Mar 23, 2026

refactor: drop dependency on nodejs-repo-tools (#501)

df3123d

GautamSharda mentioned this pull request Mar 23, 2026

migrate code from googleapis/nodejs-bigtable #7852

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Mar 25, 2026

refactor: drop dependency on nodejs-repo-tools (#501)

9c83cde

shivanee-p pushed a commit that referenced this pull request Mar 27, 2026

refactor: drop dependency on nodejs-repo-tools (#501)

822e8cf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pubsub: type check input. fixes #500#501

pubsub: type check input. fixes #500#501
ryanseys merged 2 commits intogoogleapis:masterfrom
stephenplusplus:spp--pubsub-publish-error-message

stephenplusplus commented Apr 14, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Apr 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

stephenplusplus commented Apr 14, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Apr 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants