Skip to content

feat: [asset] add support for directly attached and effective tags#4694

Merged
sofisl merged 9 commits intomainfrom
owl-bot-copy-packages-google-cloud-asset
Sep 27, 2023
Merged

feat: [asset] add support for directly attached and effective tags#4694
sofisl merged 9 commits intomainfrom
owl-bot-copy-packages-google-cloud-asset

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Sep 25, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 568643156

Source-Link: googleapis/googleapis@f95afc0

Source-Link: https://github.com/googleapis/googleapis-gen/commit/bbd2c49d2e423a8ce5cc85627402d512aeefc58b
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJiYmQyYzQ5ZDJlNDIzYThjZTVjYzg1NjI3NDAyZDUxMmFlZWZjNThiIn0=

BEGIN_NESTED_COMMIT
feat: [asset] add support for directly attached and effective tags
docs: clarify comments for tags and effective tags

Clients can search resources filtered by effective tags and start to use the new tags field instead of old tag_key, tag_value, tag_value_id fields to access directly attached tags.

PiperOrigin-RevId: 567554529

Source-Link: googleapis/googleapis@1a3ea87

Source-Link: https://github.com/googleapis/googleapis-gen/commit/df4f7ba41a807a193b48afdba8d4aef35636875a
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJkZjRmN2JhNDFhODA3YTE5M2I0OGFmZGJhOGQ0YWVmMzU2MzY4NzVhIn0=
END_NESTED_COMMIT

docs: clarify comments for tags and effective tags

Clients can search resources filtered by effective tags and start to use the new `tags` field instead of old `tag_key`, `tag_value`, `tag_value_id` fields to access directly attached tags.

PiperOrigin-RevId: 567554529

Source-Link: googleapis/googleapis@1a3ea87

Source-Link: googleapis/googleapis-gen@df4f7ba
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJkZjRmN2JhNDFhODA3YTE5M2I0OGFmZGJhOGQ0YWVmMzU2MzY4NzVhIn0=
@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 25, 2023

/gcbrun

@gcf-owl-bot gcf-owl-bot Bot marked this pull request as ready for review September 25, 2023 16:36
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team September 25, 2023 16:36
@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 25, 2023

/gcbrun

@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 25, 2023

/gcbrun

…(ESM)

PiperOrigin-RevId: 568643156

Source-Link: googleapis/googleapis@f95afc0

Source-Link: googleapis/googleapis-gen@bbd2c49
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJiYmQyYzQ5ZDJlNDIzYThjZTVjYzg1NjI3NDAyZDUxMmFlZWZjNThiIn0=
@gcf-owl-bot gcf-owl-bot Bot changed the title feat: [asset] add support for directly attached and effective tags build: [asset] update typescript generator version to publish in dual format (ESM) Sep 26, 2023
@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 26, 2023

/gcbrun

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Sep 26, 2023

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 26, 2023

/gcbrun

@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 26, 2023

/gcbrun

@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 26, 2023

/gcbrun

@sofisl sofisl changed the title build: [asset] update typescript generator version to publish in dual format (ESM) feat: [asset] add support for directly attached and effective tags Sep 27, 2023
@dpebot
Copy link
Copy Markdown
Collaborator

dpebot commented Sep 27, 2023

/gcbrun

@sofisl sofisl merged commit 5865cc3 into main Sep 27, 2023
@sofisl sofisl deleted the owl-bot-copy-packages-google-cloud-asset branch September 27, 2023 19:10
@release-please release-please Bot mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants