Skip to content

docs: use latest cloud-rad version#4142

Merged
dansaadati merged 4 commits intomainfrom
cloud-rad-version
Apr 12, 2023
Merged

docs: use latest cloud-rad version#4142
dansaadati merged 4 commits intomainfrom
cloud-rad-version

Conversation

@dansaadati
Copy link
Copy Markdown
Contributor

@dansaadati dansaadati commented Mar 29, 2023

This version update will use the refactored
nodejs-cloud-rad generator, and pull in new versions.

@dansaadati dansaadati requested review from a team and sofisl March 29, 2023 19:50
@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Mar 30, 2023

@dansaadati, have you tried publishing with this branch? Just want to make sure it works before merging!

@dansaadati dansaadati added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2023
@dansaadati
Copy link
Copy Markdown
Contributor Author

Holding off merging until logs are output: googleapis/nodejs-cloud-rad#74 and new version successfully runs.

@dansaadati dansaadati removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 11, 2023
@dansaadati
Copy link
Copy Markdown
Contributor Author

@dansaadati, have you tried publishing with this branch? Just want to make sure it works before merging!

Thanks for checking this. I made some updates to the generator to output logs, which were missing before! The docs-devsite job now runs successfully (and with expected logs).

@dansaadati dansaadati merged commit 7116b6e into main Apr 12, 2023
@dansaadati dansaadati deleted the cloud-rad-version branch April 12, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants