build: fix readme generation, do not fail if product documentation does not exist#3474
Merged
build: fix readme generation, do not fail if product documentation does not exist#3474
Conversation
sofisl
changed the title
bcoe
suggested changes
Nov 2, 2022
| method: 'HEAD', | ||
| validateStatus: () => true | ||
| }); | ||
| } catch (err) { |
There was a problem hiding this comment.
I would look at the error code and only set remoteUrlExists = false if the error returned is a 404 (indicating that it doesn't exist).
This way we don't mess up the README.md if there happen to be spurious 500s.
| supportDocsUrl = 'https://cloud.google.com/stackdriver/docs/getting-support'; | ||
| } | ||
|
|
||
| if (!supportDocsUrl.match(/https/)) { |
Contributor
There was a problem hiding this comment.
Let's do /^https:/ to avoid possible matches in the middle of the string.
alexander-fenster
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3387