fix: update typeless bot build to compile before pack#3463
Merged
bcoe merged 2 commits intogoogleapis:mainfrom Oct 28, 2022
Merged
fix: update typeless bot build to compile before pack#3463bcoe merged 2 commits intogoogleapis:mainfrom
bcoe merged 2 commits intogoogleapis:mainfrom
Conversation
Contributor
Author
|
I tested against Node 14 and 15, and it looks fine, so I moved the engines requirement down to 14 as well. |
bcoe
approved these changes
Oct 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like I was missing a "prepare" line in package.json, so the package was missing the actual code.