fix: typeless bot updates for a fully functioning packaged version#3461
Merged
feywind merged 6 commits intogoogleapis:mainfrom Oct 27, 2022
Merged
fix: typeless bot updates for a fully functioning packaged version#3461feywind merged 6 commits intogoogleapis:mainfrom
feywind merged 6 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
bcoe
approved these changes
Oct 27, 2022
bcoe
reviewed
Oct 27, 2022
| @@ -0,0 +1,25 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
Adding a shebang and bin the main differences?
Contributor
Author
There was a problem hiding this comment.
Yeah, and there are some weirdnesses around module naming/paths and ESM, so I went ahead and separated it out with the right name.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the typeless sample bot to fix some issues discovered when trying to integrate with OwlBot.