Skip to content

build: enable sentence-case plugin for release notes#3334

Merged
chingor13 merged 5 commits intomainfrom
chingor13-patch-1
Sep 30, 2022
Merged

build: enable sentence-case plugin for release notes#3334
chingor13 merged 5 commits intomainfrom
chingor13-patch-1

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Sep 9, 2022

This is used for standardizing release notes.

@chingor13 chingor13 requested a review from a team September 9, 2022 02:07
Comment thread release-please-config.json Outdated
@bcoe
Copy link
Copy Markdown

bcoe commented Sep 29, 2022

@chingor13 one thing I noticed in recent week's release notes is that the plugin isn't working for go, with this configuration:

https://github.com/googleapis/google-cloud-go/blob/main/spanner/release-please-config.json#L11

☝️ should the plugins work as a string, or should they be an object with the key type?

@bcoe bcoe assigned chingor13 and unassigned sofisl Sep 29, 2022
@chingor13
Copy link
Copy Markdown
Contributor Author

should the plugins work as a string, or should they be an object with the key type?

Either way should work. Originally, plugins were not configurable, so they could be loaded with just their name. Then we needed the ability to configure plugins, so we have an option where you provide a JSON object where the type field is the name of the plugin.

@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 30, 2022
@chingor13 chingor13 merged commit 626b1fb into main Sep 30, 2022
@chingor13 chingor13 deleted the chingor13-patch-1 branch September 30, 2022 16:03
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants