spanner: properly capture readOnly option#2561
Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom Aug 29, 2017
callmehiphop:dg--spanner-readonly-txn
Merged
spanner: properly capture readOnly option#2561stephenplusplus merged 1 commit intogoogleapis:masterfrom callmehiphop:dg--spanner-readonly-txn
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:dg--spanner-readonly-txn
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
@vkedia it's not letting me add you as a reviewer for some reason. |
callmehiphop
changed the title
vkedia
reviewed
Aug 26, 2017
| } | ||
|
|
||
| options = extend({}, options); | ||
| delete options.readOnly; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| options = extend({}, options); | ||
|
|
||
| this.readOnly = !!options.readOnly; | ||
| delete options.readOnly; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| describe('begin', function() { | ||
| var OPTIONS = { | ||
| readOnly: true, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vkedia
approved these changes
Aug 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2542