Coverage remained the same at 100.0% when pulling 09ef343 on landrito:unicode-name-check into 845cb96 on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 5ca22dd on landrito:unicode-name-check into 845cb96 on GoogleCloudPlatform:master.

I pushed a small refactor. PTAL-- most noteworthy:

• Instead of describe blocks with one test each, I just took the tests out into the general "unicode validation" describe
• When you use promises with Mocha, you can just return it to the function without calling done. Your then blocks with asserts will still run

Coverage remained the same at 100.0% when pulling f5abfce on landrito:unicode-name-check into 845cb96 on GoogleCloudPlatform:master.

Thanks for the refactor @stephenplusplus!

When you use promises with Mocha, you can just return it to the function without calling done. Your then blocks with asserts will still run

Good to know!

LGTM

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.