Skip to content

circle: refactor test script#2488

Merged
stephenplusplus merged 5 commits intogoogleapis:masterfrom
stephenplusplus:spp--circle-maybe
Jul 24, 2017
Merged

circle: refactor test script#2488
stephenplusplus merged 5 commits intogoogleapis:masterfrom
stephenplusplus:spp--circle-maybe

Conversation

@stephenplusplus
Copy link
Copy Markdown
Contributor

I'm trying to reconcile differences between how a test script should exit on AppVeyor and Circle. When one is happy (green build), the other one complains (red build). The first step is a small refactor of the test script run through Circle, so I can find focus on the controversial component.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 24, 2017
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 24, 2017
@googleapis googleapis deleted a comment from googlebot Jul 24, 2017
@googleapis googleapis deleted a comment from googlebot Jul 24, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 8c96a5a on stephenplusplus:spp--circle-maybe into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 8c96a5a on stephenplusplus:spp--circle-maybe into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 8c96a5a on stephenplusplus:spp--circle-maybe into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 6be9760 on stephenplusplus:spp--circle-maybe into ** on GoogleCloudPlatform:master**.

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

Before:

  • test.sh is called from Circle
  • test.sh runs tests for all Node versions
  • test.sh reports to coveralls with code coverage

After:

  • test.sh is called from Circle with argument "4"
  • test.sh runs tests for called version (4)
  • Circle reports to coveralls with code coverage
  • test.sh is called from Circle with argument "6"
  • test.sh is called from Circle with argument "7"
  • test.sh is called from Circle with argument "8"

This has a couple benefits that I see:

  • More configuration is moved to the Circle UI. This makes it easier to test settings without these backwards CI-poking PRs.
  • Logging output is less likely to be collapsed by the UI, where Circle forces you to download the raw .txt log file. This is because each Node version now gets its own allowance.

Here is what the Circle UI "test" task is configured to run now:

git config --global user.name "circle-ci"
git config --global user.email "[email protected]"
. scripts/circle/test.sh 4
export COVERALLS_REPO_TOKEN="vKZ7a3PpW0lRBRWC12dPw2EiZE5ml962J"; npm run coveralls
. scripts/circle/test.sh 6
. scripts/circle/test.sh 7
. scripts/circle/test.sh 8

Let's see how this goes.

@stephenplusplus stephenplusplus merged commit 5883af7 into googleapis:master Jul 24, 2017
sofisl pushed a commit that referenced this pull request Feb 25, 2026
* ci: Enable `constraintsFiltering` for Node.js Libraries

chore: Enable `constraintsFiltering` for Node.js Libraries

Source-Link: googleapis/synthtool@dae1282
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d920257482ca1cd72978f29f7d28765a9f8c758c21ee0708234db5cf4c5016c2

* add constraints filtering to renovate.json

* add internal-tooling to eslintignore

* add eslint disables for internal tooling

* fix rule names

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <[email protected]>
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
)

* ci: Enable `constraintsFiltering` for Node.js Libraries

chore: Enable `constraintsFiltering` for Node.js Libraries

Source-Link: googleapis/synthtool@dae1282
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:d920257482ca1cd72978f29f7d28765a9f8c758c21ee0708234db5cf4c5016c2

* add constraints filtering to renovate.json

* add internal-tooling to eslintignore

* add eslint disables for internal tooling

* fix rule names

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants