Skip to content

spanner: fix stream destroy bug#2358

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:dg--spanner-stream-destroy
Jun 5, 2017
Merged

spanner: fix stream destroy bug#2358
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:dg--spanner-stream-destroy

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

Relates to #2356

@callmehiphop callmehiphop added api: spanner Issues related to the Spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 5, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.988% when pulling 8469a50 on callmehiphop:dg--spanner-stream-destroy into 925e651 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 03c276d into googleapis:master Jun 5, 2017
@Chipintoza
Copy link
Copy Markdown

I update transaction.js
it looks request stream also doesn't have end()

noStatus - TypeError: this.stream.end is not a function
at StreamProxy._onFinish (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/google-gax/lib/streaming.js:103:17)
at StreamProxy. (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/google-gax/lib/streaming.js:76:10)
at emitNone (events.js:86:13)
at StreamProxy.emit (events.js:185:7)
at finishMaybe (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/readable-stream/lib/_stream_writable.js:504:14)
at endWritable (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/readable-stream/lib/_stream_writable.js:514:3)
at StreamProxy.Writable.end (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/readable-stream/lib/_stream_writable.js:484:41)
at StreamProxy. (/Users/Chipintoza/GSS Projects/accounts.gss.ge/node_modules/@google-cloud/spanner/src/transaction.js:374:23)
at emitOne (events.js:96:13)
at StreamProxy.emit (events.js:188:7)

@Chipintoza
Copy link
Copy Markdown

please look comment

sofisl pushed a commit that referenced this pull request Feb 26, 2026
sofisl pushed a commit that referenced this pull request Feb 26, 2026
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants