Skip to content

spanner: make getTransaction public#2344

Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom
callmehiphop:dg--spanner-txn-promises
Jun 26, 2017
Merged

spanner: make getTransaction public#2344
stephenplusplus merged 2 commits intogoogleapis:masterfrom
callmehiphop:dg--spanner-txn-promises

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

@callmehiphop callmehiphop commented May 31, 2017

Closes #2152

@callmehiphop callmehiphop added the api: spanner Issues related to the Spanner API. label May 31, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2017
@bjwatson bjwatson requested a review from vkedia May 31, 2017 21:30
@bjwatson
Copy link
Copy Markdown

bjwatson commented May 31, 2017

Thanks @callmehiphop! Adding @vkedia as a reviewer, since he understands this code better than I do.

@bjwatson bjwatson requested a review from swcloud May 31, 2017 21:31
@coveralls
Copy link
Copy Markdown

coveralls commented May 31, 2017

Coverage Status

Coverage remained the same at 99.988% when pulling 45bbb6f on callmehiphop:dg--spanner-txn-promises into 748816f on GoogleCloudPlatform:master.

vkedia
vkedia reviewed Jun 6, 2017
View reviewed changes
Comment thread packages/spanner/src/database.js Outdated
* Get a read/write ready Transaction object.
*
* @param {object=} options - Transaction options.
* @param {boolean} options.readOnly - Specifies if the transaction is read

This comment was marked as spam.

Sign in to view

Comment thread packages/spanner/src/database.js Outdated
/**
* Get a read/write ready Transaction object.
*
* @param {object=} options - Transaction options.

This comment was marked as spam.

Sign in to view

Comment thread packages/spanner/src/database.js
var transaction = self.pool_.createTransaction_(session, options);

transaction.begin(function(err) {
if (err) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@bjwatson
Copy link
Copy Markdown

bjwatson commented Jun 20, 2017

@callmehiphop Can you close this out this week?

@callmehiphop
Copy link
Copy Markdown
Contributor Author

callmehiphop commented Jun 20, 2017

@bjwatson yes! Sorry, I've been side tracked by other things.

@bjwatson
Copy link
Copy Markdown

bjwatson commented Jun 20, 2017

Thanks @callmehiphop!

@bjwatson
Copy link
Copy Markdown

bjwatson commented Jun 21, 2017

@swcloud FYI, we want to get this done this week.

@callmehiphop
Copy link
Copy Markdown
Contributor Author

callmehiphop commented Jun 26, 2017

@stephenplusplus @vkedia this should be good to go now!

stephenplusplus
stephenplusplus suggested changes Jun 26, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/spanner/src/database.js

/**
* Get a read/write ready Transaction object.
*

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus merged commit ca0d96c into googleapis:master Jun 26, 2017
This was referenced Jul 5, 2017
Merged
Merged
sofisl pushed a commit that referenced this pull request Feb 25, 2026
@release-please
chore(main): release 7.4.0 (#2344)
367d265 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Feb 26, 2026
@callmehiphop @stephenplusplus
spanner: make getTransaction public (#2344)
f7d6b74
sofisl pushed a commit that referenced this pull request Feb 26, 2026
@gcf-owl-bot
chore: add node 24 in node ci test (#2344)
1142c53 
Source-Link: googleapis/synthtool@1218bc2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:66c44f0ad8f6caaa4eb3fbe74f8c2b4de5a97c2b930cee069e712c447723ba95

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
@release-please
chore(main): release 7.4.0 (googleapis#2344)
89a6b5a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjwatson bjwatson Awaiting requested review from bjwatson

@swcloud swcloud Awaiting requested review from swcloud

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus requested changes

@vkedia vkedia vkedia left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@callmehiphop @bjwatson @coveralls @stephenplusplus @vkedia @googlebot