Improve our coverage configuration.#2134
Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom Mar 24, 2017
Merged
Conversation
The first step to fixing it. :-)
googlebot
added
the
cla: yes
Contributor
Contributor
Author
|
Edited. Everything else look good to you? |
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
* feat: manual proto pushing * feat: manually push protos * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to get started fixing our coverage. It annoys me that it is at 99% and coveralls gives us a big fat red ❌.
This is the first step, which is making the reporting better. This PR:
npm run cover-htmlcommand to get an HTML report..istanbul.ymlconfig file, which notably changes the reporting threshholds. Now we get red below 95% and yellow below 100%. The defaults on Istanbul (50% and 80%) are ridiculous and show up green even when you are missing a lot of coverage..coveragedirectory (note the leading dot), because I am OCD and really hate seeing it on a defaultls. The.gitignoreandnpm run coverallsare updated accordingly.