Skip to content

fix(util): broken URL to auth docs#1918

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
DevIntent:fixBrokenAuthDocsLink
Jan 19, 2017
Merged

fix(util): broken URL to auth docs#1918
stephenplusplus merged 1 commit intogoogleapis:masterfrom
DevIntent:fixBrokenAuthDocsLink

Conversation

@Splaktar
Copy link
Copy Markdown
Contributor

@Splaktar Splaktar commented Jan 11, 2017

Error: Sorry, we cannot connect to Google Cloud Services without a project ID. You may specify one with an environment variable named "GCLOUD_PROJECT". See https://googlecloudplatform.github.io/google-cloud-node/#//docs/guides/authentication for a detailed guide on creating an authenticated connection.

The current link in this message opens https://googlecloudplatform.github.io/google-cloud-node/#/ and not the auth docs.

Removing the extra / properly routes to https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud/0.45.0/guides/authentication

Relates to #1405

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2017
@stephenplusplus
Copy link
Copy Markdown
Contributor

Thank you! Which browser are you using? The original link works for me, as well as the new one, so it shouldn't be a problem to merge. Just want to make sure we're solving the real problem.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 1dcca1b on DevIntent:fixBrokenAuthDocsLink into ee64b07 on GoogleCloudPlatform:master.

@Splaktar
Copy link
Copy Markdown
Contributor Author

Splaktar commented Jan 12, 2017

Chrome Version 55.0.2883.95 (64-bit), sorry for the delay.

@Splaktar
Copy link
Copy Markdown
Contributor Author

Added the current link as a clickable link in the PR description to make sure that you were testing with the right link.

@stephenplusplus stephenplusplus merged commit fd22ba5 into googleapis:master Jan 19, 2017
@stephenplusplus
Copy link
Copy Markdown
Contributor

Sorry for my delay, too. And thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants