common: fix auto-detected projectId assignment#1878
Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom Dec 12, 2016
Merged
common: fix auto-detected projectId assignment#1878stephenplusplus merged 2 commits intogoogleapis:masterfrom
stephenplusplus merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
stephenplusplus
added
type: bug
googlebot
added
the
cla: yes
stephenplusplus
force-pushed
the
spp--1877
branch
from
40d359f to
1988fcd
Compare
|
Changes Unknown when pulling 1988fcd on stephenplusplus:spp--1877 into ** on GoogleCloudPlatform:master**. |
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
🤖 I have created a release *beep* *boop* --- ## [6.13.0](https://togithub.com/googleapis/nodejs-spanner/compare/v6.12.0...v6.13.0) (2023-07-21) ### Features * Enable leader aware routing by default. This update contains performance optimisations that will reduce the latency of read/write transactions that originate from a region other than the default leader region. ([87cd5e6](https://togithub.com/googleapis/nodejs-spanner/commit/87cd5e6ecdf6d888dd0e7fe712b7070c58b32d42)) ### Bug Fixes * **deps:** Update dependency yargs to v17 ([#1866](https://togithub.com/googleapis/nodejs-spanner/issues/1866)) ([24e321f](https://togithub.com/googleapis/nodejs-spanner/commit/24e321f6327cfdfc191a84bb47d80a156eff5be9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
…#1878) * feat: Trusted Private Cloud support, use the universeDomain parameter feat: auto populate UUID fields where needed fix: revert changes to streaming retries Use gapic-generator-typescript v4.4.0. PiperOrigin-RevId: 603757799 Source-Link: googleapis/googleapis@1a45bf7 Source-Link: googleapis/googleapis-gen@19ca4b4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTljYTRiNDVhNTNkMDBjYjdiZGQ5NGI0NDJiNjBiZDIzN2RmZTEyMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
GautamSharda
pushed a commit
that referenced
this pull request
Mar 12, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Mar 17, 2026
* fix: Disable Universe Domain Check * chore: compodoc nonsense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught this while testing out a bug. Our code mistakenly considered our
projectIdplaceholder value ({{projectId}}) as a user-set projectId. Additionally, we were not swapping the placeholder for the actual value inside of API requests with nested arrays.