Skip to content

resource: add promise support#1709

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:promise-resource-support
Oct 17, 2016
Merged

resource: add promise support#1709
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:promise-resource-support

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

Breaking changes ahead! ⚠️

This adds Promise support for the @google-cloud/resource module!

Summary of changes

The following methods previously returned a stream in the event that the callback parameter was omitted. This functionality has since moved to a different method entirely.

  • Resource#getProjects -> Resource#getProjectsStream

Each callback accepting change has also been updated to return a Promise instance in the event that thecallback was omitted.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2016
@callmehiphop callmehiphop mentioned this pull request Oct 17, 2016
48 tasks
@stephenplusplus stephenplusplus merged commit 2465874 into googleapis:master Oct 17, 2016
sofisl pushed a commit that referenced this pull request Oct 12, 2022
sofisl pushed a commit that referenced this pull request Feb 25, 2026
🤖 I have created a release \*beep\* \*boop\*
---
## [5.16.0](https://www.github.com/googleapis/nodejs-storage/compare/v5.15.5...v5.16.0) (2021-11-09)


### Features

* improved error messages for resumable uploads ([#1708](https://www.github.com/googleapis/nodejs-storage/issues/1708)) ([50cdbb6](https://www.github.com/googleapis/nodejs-storage/commit/50cdbb6f730ee7f96cb598c4cda412fc4bcc8807))


### Bug Fixes

* add scenario 3 conformance tests ([#1702](https://www.github.com/googleapis/nodejs-storage/issues/1702)) ([e16a3a5](https://www.github.com/googleapis/nodejs-storage/commit/e16a3a5eb09a388743259d54c31e62d7fc220bf0))
* retry uri creation dep update & conformance tests ([#1700](https://www.github.com/googleapis/nodejs-storage/issues/1700)) ([d265f8c](https://www.github.com/googleapis/nodejs-storage/commit/d265f8c5e4e6a8c8239e959dfb4d0acbf4cdfe0a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda pushed a commit that referenced this pull request Mar 11, 2026
…ivery correctly (#1709)

* fix: don't try to lease messages with failed acks in exactly-once delivery

* fix: don't pass messages to clients or start leasing in exactly-once delivery if the receipt modAck fails

* fix: handle receipt modAcks and lease extensions properly with exactly-once delivery enabled

* fix: permanently fail any ack/modAck/nack that fails once under exactly-once delivery
sofisl added a commit that referenced this pull request Mar 17, 2026
* Update package.json

* chore: update commands

* checkout main

* restore package.json files
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
🤖 I have created a release \*beep\* \*boop\*
---
## [5.16.0](https://www.github.com/googleapis/nodejs-storage/compare/v5.15.5...v5.16.0) (2021-11-09)


### Features

* improved error messages for resumable uploads ([googleapis#1708](https://www.github.com/googleapis/nodejs-storage/issues/1708)) ([b7d0d74](https://www.github.com/googleapis/nodejs-storage/commit/b7d0d74581295616734cd3a3255e775165fb1ca5))


### Bug Fixes

* add scenario 3 conformance tests ([googleapis#1702](https://www.github.com/googleapis/nodejs-storage/issues/1702)) ([82fa1e0](https://www.github.com/googleapis/nodejs-storage/commit/82fa1e038892050775a9bc3e170ccf1e5c0c0ef3))
* retry uri creation dep update & conformance tests ([googleapis#1700](https://www.github.com/googleapis/nodejs-storage/issues/1700)) ([27932b0](https://www.github.com/googleapis/nodejs-storage/commit/27932b04a771c3b6044c473fd555f7ef2d25f0dd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants