Introduce auto-generated Gapic client for speech API#1614
Introduce auto-generated Gapic client for speech API#1614stephenplusplus merged 6 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
|
cc: @jmdobry |
|
Changes Unknown when pulling 5d196e1 on jmuk:speech into * on GoogleCloudPlatform:master*. |
|
LGTM. Once this is merged, I feel we should evaluate whether to cut a release before changing the hand-written stuff to use the autogen stuff under the hood (my vote is to update the hand-written stuff). It probably wouldn't be much work, and it'd be nice to catch any possible breaking changes sooner rather than after we've already released 0.1.0. |
| */ | ||
| Speech.detectEncoding_ = function(filename) { | ||
| if (!is.string(filename)) { | ||
| // istanbul ignore next |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 191474d on jmuk:speech into * on GoogleCloudPlatform:master*. |
|
Changes Unknown when pulling d602ee1 on jmuk:speech into * on GoogleCloudPlatform:master*. |
| }); | ||
|
|
||
| it('should return nothing if the argument is not a string', function() { | ||
| assert.equal(Speech.detectEncoding_({}), undefined); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jmuk Looks like we need an update with the latest protos: googleapis/googleapis#153 |
|
I subscribed to the PR, but if I miss it, please ping me and I'll make a new release to |
|
Thanks for adding the test and syncing with master. Do I need to cut a new |
|
Seems it's not necessary to create a new version of |
|
Okay, we can wait on that then. I'll merge this once CI says it's happy. |
|
Changes Unknown when pulling b9507ef on jmuk:speech into * on GoogleCloudPlatform:master*. |
|
@jmuk @stephenplusplus Looks like @landrito has pushed the proto updates to Github: googleapis/googleapis@57bf535 |
* fix: add hashes to requirements.txt and update Docker images so they require hashes. * fix: add hashes to docker/owlbot/java/src * Squashed commit of the following: commit ab7384ea1c30df8ec2e175566ef2508e6c3a2acb Author: Jeffrey Rennie <[email protected]> Date: Tue Aug 23 11:38:48 2022 -0700 fix: remove pip install statements (#1546) because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 commit 302667c9ab7210da42cc337e8f39fe1ea99049ef Author: WhiteSource Renovate <[email protected]> Date: Tue Aug 23 19:50:28 2022 +0200 chore(deps): update dependency setuptools to v65.2.0 (#1541) Co-authored-by: Anthonios Partheniou <[email protected]> commit 6e9054fd91d1b500cae58ff72ee9aeb626077756 Author: WhiteSource Renovate <[email protected]> Date: Tue Aug 23 19:42:51 2022 +0200 chore(deps): update dependency nbconvert to v7 (#1543) Co-authored-by: Anthonios Partheniou <[email protected]> commit d229a1258999f599a90a9b674a1c5541e00db588 Author: Alexander Fenster <[email protected]> Date: Mon Aug 22 15:04:53 2022 -0700 fix: update google-gax and remove obsolete deps (#1545) commit 13ce62621e70059b2f5e3a7bade735f91c53339c Author: Jeffrey Rennie <[email protected]> Date: Mon Aug 22 11:08:21 2022 -0700 chore: remove release config and script (#1540) We don't release to pypi anymore. * chore: rollback java changes to move forward with other languages until Java's docker image is fixed Source-Link: googleapis/synthtool@4826337 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:7fefeb9e517db2dd8c8202d9239ff6788d6852bc92dd3aac57a46059679ac9de Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix: update various dependencies
6 participants
No description provided.